Conversation
Install these companion packages unpinned from PyPI instead of fixed git refs (commit hash / tag), so the dt4acc smoke test stays current with newly published releases instead of testing a stale snapshot. Fixes #416
3 tasks
JeanLucPons
previously approved these changes
Sep 14, 2026
Member
Author
|
@TeresiaOlsson, @JeanLucPons, what do you prefer? Should I point it to:
Personally, I lean toward option 1, but I’m happy to go with the consensus. I don't have a strong opinion either way. |
Member
Author
|
@JeanLucPons, thanks for the review! Just a heads-up: I'll need to update the BESSY II example to match the PyPI version, which will dismiss your review. |
Member
|
I agree with point 1 |
Install these companion packages unpinned from PyPI instead of fixed git refs (commit hash / tag), so the dt4acc smoke test stays current with newly published releases instead of testing a stale snapshot. Fixes #416
Member
Me too. It feels more robust to me to always test against latest release. Then at least the tests runs against a stable source. |
gubaidulinvadim
previously approved these changes
Sep 14, 2026
gubaidulinvadim
self-requested a review
September 14, 2026 14:08
gubaidulinvadim
dismissed
their stale review
September 14, 2026 14:09
Why is the smoke test still failling?
Install these companion packages unpinned from PyPI instead of fixed git refs (commit hash / tag), so the dt4acc smoke test stays current with newly published releases instead of testing a stale snapshot. Fixes #416
Member
Author
|
@gubaidulinvadim, the test is fine now. |
gubaidulinvadim
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install these companion packages unpinned from PyPI instead of fixed git refs (commit hash / tag), so the dt4acc smoke test stays current with newly published releases instead of testing a stale snapshot.
Fixes #416