Skip to content

Fix: check the right matching the model behavior - #664

Merged
RomainLvr merged 1 commit into
mainfrom
fix_model
Sep 10, 2026
Merged

Fix: check the right matching the model behavior#664
RomainLvr merged 1 commit into
mainfrom
fix_model

Conversation

@stonebuzz

Copy link
Copy Markdown
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • A model allowed to update existing items was accepted as soon as the user held the creation right on the imported itemtypes, so an import could rewrite items the profile is not allowed to modify.
  • The required right is now derived from what the model is actually allowed to do: creation right for a model that adds lines, update right for a model that updates lines, and the same right is verified again just before each write.
  • Imported user passwords were written directly in the database, which skipped the configured password policy, left the password expiration date unchanged and logged nothing in the item history.
  • Passwords are now set through the standard user update, so the policy, the expiration date and the history all apply.

Screenshots (if appropriate):

@stonebuzz
stonebuzz force-pushed the fix_model branch 2 times, most recently from 6c1b7b9 to 127a557 Compare September 10, 2026 06:16
@RomainLvr
RomainLvr merged commit 1b64466 into main Sep 10, 2026
3 checks passed
@RomainLvr
RomainLvr deleted the fix_model branch September 10, 2026 07:51
stonebuzz added a commit that referenced this pull request Sep 10, 2026
Co-authored-by: Stanislas Kita <7335054+stonebuzz@users.noreply.github.com>
(cherry picked from commit 1b64466)
stonebuzz added a commit that referenced this pull request Sep 10, 2026
Co-authored-by: Stanislas Kita <7335054+stonebuzz@users.noreply.github.com>
(cherry picked from commit 1b64466)
RomainLvr pushed a commit that referenced this pull request Sep 10, 2026
(cherry picked from commit 1b64466)

Co-authored-by: Stanislas Kita <7335054+stonebuzz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants