Skip to content

fix: Update mocks to use specific date strings - #7970

Merged
camdecoster merged 2 commits into
masterfrom
cam/7969/update-mocks-time-data-points
Aug 18, 2026
Merged

fix: Update mocks to use specific date strings#7970
camdecoster merged 2 commits into
masterfrom
cam/7969/update-mocks-time-data-points

Conversation

@camdecoster

@camdecoster camdecoster commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Description

Update four mocks to make date strings unambiguous.

Closes #7969.

Changes

  • Update mock data

Testing

  • Be on master
  • Open plotly devtools
  • Render the following mocks with this command: npm run baseline axes_breaks domain_ref_axis_types ohlc_first range_selector_style
    • test/image/mocks/axes_breaks.json
    • test/image/mocks/domain_ref_axis_types.json
    • test/image/mocks/ohlc_first.json
    • test/image/mocks/range_selector_style.json
  • Look at the git status and note that they all change
  • Switch to this branch
  • Run the render command again
  • Note that the images now show no diff

Notes

  • I've spent some time chasing this issue as a bug that I introduced when it was unrelated
  • Fixing this so I don't do that again
  • Another way to see the issue is to run the render command on master, but setting the timezone to UTC: TZ=UTC npm run baseline.... This runs the render in the same TZ as CI, and no diff is present.

@camdecoster camdecoster added the no-draftlog The associated PR doesn't require a draftlog and the CI check will be skipped. label Aug 17, 2026
emilykl
emilykl previously approved these changes Aug 17, 2026

@emilykl emilykl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@camdecoster
camdecoster merged commit 38a48b7 into master Aug 18, 2026
85 checks passed
@camdecoster
camdecoster deleted the cam/7969/update-mocks-time-data-points branch August 18, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-draftlog The associated PR doesn't require a draftlog and the CI check will be skipped.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Some mocks with time data don't render proper in non-UTC time zones

2 participants