Skip to content

fix(server): load only due tasks during scheduler ticks - #9925

Open
saphid wants to merge 386 commits into
pingdotgg:t3code/codex-turn-mappingfrom
saphid:fix/v2-scheduled-due-query-20260905
Open

fix(server): load only due tasks during scheduler ticks#9925
saphid wants to merge 386 commits into
pingdotgg:t3code/codex-turn-mappingfrom
saphid:fix/v2-scheduled-due-query-20260905

Conversation

@saphid

@saphid saphid commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

The five-second scheduler tick decoded every task, including disabled and future tasks. Query only enabled, due, non-running rows through the existing partial due-task index. Preserve task order and lenient handling of malformed due rows; API listing and one-time startup recovery retain their full reads.

Rebuilt head f4b5f8a06 targets V2 3aa47e294, with test-only prerequisite #10865 (merge first). Two-file topic, no schema changes.

Validation: all seven focused scheduler/query tests pass, including index selection, malformed records, running/disabled/future rows. Server typecheck, targeted lint and formatting pass. No live state writes. New CI pending. Direct Claude Opus 5 high review remains unavailable because OAuth expired (latest launch exited 1 before inference).

Targets V2 #2829. Updated with GPT-6 in Codex/T3.

@cursor

cursor Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

This PR is too large for Bugbot to review. It changes 99,212 lines and 4,021,181 characters. Split the change into smaller pull requests to get a review.

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Sep 5, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Macroscope has since reviewed this pull request. An earlier review was skipped by a cost limit; a review has now completed, so that notice no longer applies.

@github-actions github-actions Bot added the size:XXL 1,000+ changed lines (additions + deletions). label Sep 5, 2026
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch from b82facd to 2ac9bfe Compare September 5, 2026 04:56
@macroscopeapp

macroscopeapp Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at f4b5f8a

Macroscope's review found this PR approvable — This is a focused scheduler optimization that moves existing due-task filtering into an indexed query while preserving lenient decoding and existing task behavior. Added tests cover the relevant task states, and no product defaults or production interfaces are changed.

You can add or adjust custom eligibility rules. Learn more.

@saphid
saphid force-pushed the fix/v2-scheduled-due-query-20260905 branch from aa837b8 to f106115 Compare September 5, 2026 05:11
@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Sep 5, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 5, 2026
Comment thread apps/server/src/scheduledTasks/ScheduledTaskService.ts Outdated
@macroscopeapp
macroscopeapp Bot dismissed their stale review September 6, 2026 05:00

Dismissing prior approval to re-evaluate d05a0ba

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 6, 2026
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 2 times, most recently from 9242b91 to 3d81172 Compare September 8, 2026 03:31
@macroscopeapp
macroscopeapp Bot dismissed their stale review September 8, 2026 05:55

Dismissing prior approval to re-evaluate ebc4cd5

@github-actions github-actions Bot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Sep 8, 2026
juliusmarminge and others added 12 commits September 7, 2026 23:12
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
- Re-route steering that races completion into idempotent follow-up dispatches
- Preserve scheduled-task attribution and provider ownership history across clients
Port main's pull-request discovery, active thread ordering, async question dismissal, settlement fixes, provider-session import, attachment context, and provider correctness changes into orchestration v2.

Keep the branch's intentional composer and subagent behavior while adopting main's web and mobile fixes. Prevent headless setup terminals from hanging on the color probe, and move the v2 migration block to 050-061 after main claimed 048-049.
Restore the failed-before-start timer guard, align two server fixtures with the reconciled behavior, and remove dead files, exports, and dependencies surfaced by Knip.

Drop the temporary branch push trigger now that the PR is mergeable, so each update runs the pull-request workflow once.
Keep main's batch machine-update banner and update action while preserving the v2 runtime-based environment lock used by draft load balancing.
Adopt TypeScript 7 and Effect rc.112 across orchestration v2, including the TaggedError API migration and updated Effect-aware tests. Restore main's composer-aware scroll-to-end clearance while retaining selected-model settings sync, preview recording transfer, image galleries, desktop context menus, and layout hit targets. Regenerate the lockfile on the upgraded dependency baseline.
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch from efd9994 to 6102d00 Compare September 8, 2026 06:23
juliusmarminge and others added 7 commits September 8, 2026 14:26
Advertise bounded socket snapshots and authoritative dispatch validation, omit raw command output and inline file bodies at the wire boundary, and preserve compact status metadata across web and mobile. Add transport-budget coverage for snapshots, resume, commands, legacy import, and projection maintenance.
Restore pinned-thread shelf classification, server-owned unread state, hidden-subagent-safe project ordering, guarded jump hints, draft upload cleanup, and active-provider archive guards across the current and legacy sidebars.

Bring the surrounding current-main sidebar work forward as well: canonical project favicons, stable row layout, thread file drops, account-aware mobile provider badges, and deferred desktop keyring loading.
@saphid
saphid force-pushed the fix/v2-scheduled-due-query-20260905 branch from ebc4cd5 to f4b5f8a Compare September 9, 2026 01:03
@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Sep 9, 2026
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch from 8187b17 to ada72ce Compare September 9, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants