fix(server): retry transient V2 initial title failures - #9908
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped server fix that adds a bounded retry policy for transient initial title-generation failures and introduces additive typed error distinctions to avoid retrying unavailable providers or CLIs. Supporting tests cover recovery, retry exhaustion, and non-retryable failures, with no product-default or deployment changes. You can add or adjust custom eligibility rules. Learn more. |
b82facd to
2ac9bfe
Compare
9b50fec to
57ba3e6
Compare
There was a problem hiding this comment.
reviewed diff and relevant surrounding code at 1d528851d9e0a5b6e3171da0b8b29bfdd7f678ed. no blocking findings.
retry wraps the request-id check, so each attempt rechecks staleness. retries remain bounded and initial-only; explicit non-retryable errors and interruption retain their separate paths. reviewed the recovery/exhaustion/non-retryable tests and the resolved prior finding. no code changes needed. the effect suite was not rerun locally.
ci snapshot: no failing or pending checks; some checks are skipped. this is a comment review, not an approval or merge.
This comment has been minimized.
This comment has been minimized.
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Dismissing prior approval to re-evaluate e3e526a
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Dismissing prior approval to re-evaluate f99466c
This comment has been minimized.
This comment has been minimized.
9242b91 to
3d81172
Compare
Dismissing prior approval to re-evaluate e0357f4
Port main's pull-request discovery, active thread ordering, async question dismissal, settlement fixes, provider-session import, attachment context, and provider correctness changes into orchestration v2. Keep the branch's intentional composer and subagent behavior while adopting main's web and mobile fixes. Prevent headless setup terminals from hanging on the color probe, and move the v2 migration block to 050-061 after main claimed 048-049.
Restore the failed-before-start timer guard, align two server fixtures with the reconciled behavior, and remove dead files, exports, and dependencies surfaced by Knip. Drop the temporary branch push trigger now that the PR is mergeable, so each update runs the pull-request workflow once.
Keep main's batch machine-update banner and update action while preserving the v2 runtime-based environment lock used by draft load balancing.
Adopt TypeScript 7 and Effect rc.112 across orchestration v2, including the TaggedError API migration and updated Effect-aware tests. Restore main's composer-aware scroll-to-end clearance while retaining selected-model settings sync, preview recording transfer, image galleries, desktop context menus, and layout hit targets. Regenerate the lockfile on the upgraded dependency baseline.
efd9994 to
6102d00
Compare
|
Macroscope has since reviewed this pull request. An earlier review was skipped by a cost limit; a review has now completed, so that notice no longer applies. |
1d0f07e to
2dcd771
Compare
Advertise bounded socket snapshots and authoritative dispatch validation, omit raw command output and inline file bodies at the wire boundary, and preserve compact status metadata across web and mobile. Add transport-budget coverage for snapshots, resume, commands, legacy import, and projection maintenance.
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Dismissing prior approval to re-evaluate 988aa94
8187b17 to
ada72ce
Compare
Initial V2 title generation now retries transient provider failures twice with exponential backoff, rechecking that the request is current. Missing-provider and missing-CLI failures use distinct typed errors and do not retry. Exhaustion keeps the existing title and clears the marker; explicit regeneration remains single-attempt. JSON title envelopes are decoded before normalization and truncation.
Current head
988aa940dincludes current V2 base7dd9873edand the shared test-only prerequisite #10865. Merge #10865 first; the topic itself changes 10 files. This rebuild removes the obsolete merged-base history from the PR diff.Validation: 113 focused tests pass across the affected feature and foundation persistence coverage. Scoped server typecheck passes (plus contracts for title generation); targeted lint, formatting and diff checks pass. New-head CI is pending.
Independent cross-provider review was unavailable: the direct Claude Opus 5 high launcher in this audit exited 1 with expired OAuth before inference. No Claude review is claimed.
Targets Orchestrator V2 in #2829. Updated with GPT-6 in Codex/T3.