fix(server): reconcile historical V2 migration manifests by saphid · Pull Request #9900 · pingdotgg/t3code

saphid · 2026-09-05T04:17:11Z

Historical V2 builds recorded the same setup under different migration numbers. After V2 consolidated its schema into migration 050, those ledgers can skip missing schema or replay DDL against existing tables.

Head 9e3929026 integrates V2 fdfadf3d0, validates the historical manifest, fills missing main migrations, and runs only the remaining V2 setup steps before consolidating the ledger. Existing import progress and the original migration-050 timestamp are preserved. Main-only migration ceilings leave partial V2 progress intact for the next full upgrade. All reconciliation remains transactional.

Includes the test-only prerequisite #10865; merge it first.

Verification: 20 focused tests across four migration suites pass, covering historical bases 43/44/47/49, partial and complete V2 sequences, rollback, timestamp/import preservation, and the consolidated schema. Server typecheck and scoped lint pass. A standalone server export scan reports pre-existing unused exports across V2, so it is not recorded as a passing check. Direct independent Claude review remains unavailable because the launcher exits 1 on expired OAuth before inference.

Implemented and verified with GPT-6 Astra in the Codex harness.

macroscopeapp · 2026-09-05T04:22:14Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The PR adds substantial production startup logic for validating and reconciling historical SQLite migration ledgers, including ledger rewrites and conditional DDL execution across several schema histories. Its tests are comprehensive, but the migration-state and database-schema impact merits human review.

^{You can add or adjust custom eligibility rules. Learn more.}

cursor · 2026-09-07T08:08:13Z

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

Co-authored-by: codex <codex@users.noreply.github.com>

- Re-route steering that races completion into idempotent follow-up dispatches - Preserve scheduled-task attribution and provider ownership history across clients

Port main's pull-request discovery, active thread ordering, async question dismissal, settlement fixes, provider-session import, attachment context, and provider correctness changes into orchestration v2. Keep the branch's intentional composer and subagent behavior while adopting main's web and mobile fixes. Prevent headless setup terminals from hanging on the color probe, and move the v2 migration block to 050-061 after main claimed 048-049.

Restore the failed-before-start timer guard, align two server fixtures with the reconciled behavior, and remove dead files, exports, and dependencies surfaced by Knip. Drop the temporary branch push trigger now that the PR is mergeable, so each update runs the pull-request workflow once.

Keep main's batch machine-update banner and update action while preserving the v2 runtime-based environment lock used by draft load balancing.

Adopt TypeScript 7 and Effect rc.112 across orchestration v2, including the TaggedError API migration and updated Effect-aware tests. Restore main's composer-aware scroll-to-end clearance while retaining selected-model settings sync, preview recording transfer, image galleries, desktop context menus, and layout hit targets. Regenerate the lockfile on the upgraded dependency baseline.

Advertise bounded socket snapshots and authoritative dispatch validation, omit raw command output and inline file bodies at the wire boundary, and preserve compact status metadata across web and mobile. Add transport-budget coverage for snapshots, resume, commands, legacy import, and projection maintenance.

Restore pinned-thread shelf classification, server-owned unread state, hidden-subagent-safe project ordering, guarded jump hints, draft upload cleanup, and active-provider archive guards across the current and legacy sidebars. Bring the surrounding current-main sidebar work forward as well: canonical project favicons, stable row layout, thread file drops, account-aware mobile provider badges, and deferred desktop keyring loading.

… IDs

macroscopeapp

All clear

^{Posted via Macroscope — Effect Service Conventions}

macroscopeapp · 2026-09-09T00:44:02Z

All clear

^{Posted via Macroscope — Effect Service Conventions}

github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 5, 2026

juliusmarminge force-pushed the t3code/codex-turn-mapping branch 2 times, most recently from b82facd to 2ac9bfe Compare September 5, 2026 04:56

saphid force-pushed the fix/v2-historical-migrations-20260905 branch from bd245a3 to c45eb66 Compare September 5, 2026 05:07

juliusmarminge force-pushed the t3code/codex-turn-mapping branch 2 times, most recently from 9242b91 to 3d81172 Compare September 8, 2026 03:31

juliusmarminge and others added 21 commits September 7, 2026 23:12

fix(cursor): log close attempts before execution

e6d5c09

Co-authored-by: codex <codex@users.noreply.github.com>

fix(acp): discover final teardown descendants

b13443d

Co-authored-by: codex <codex@users.noreply.github.com>

fix(checkpoints): preserve valid run history

03d044b

Co-authored-by: codex <codex@users.noreply.github.com>

fix(orchestration): preserve imported conversation state

3c658ad

Co-authored-by: codex <codex@users.noreply.github.com>

fix(acp): enforce task and permission invariants

c252769

Co-authored-by: codex <codex@users.noreply.github.com>

fix(testkit): harden provider replay recording

5941af5

Co-authored-by: codex <codex@users.noreply.github.com>

fix(server): isolate deterministic attachment ids

3d4a365

Co-authored-by: codex <codex@users.noreply.github.com>

fix(claude): preserve explicit model options

e596525

Co-authored-by: codex <codex@users.noreply.github.com>

fix(web): enforce secure provider field defaults

eb63d51

Co-authored-by: codex <codex@users.noreply.github.com>

fix(client): preserve live thread relationships

3cbe7fb

Co-authored-by: codex <codex@users.noreply.github.com>

fix(checkpoints): retain thread-start baseline after failed runs

12fbe64

Co-authored-by: codex <codex@users.noreply.github.com>

fix(mobile): gate thread controls on live runs

4ce4c48

Co-authored-by: codex <codex@users.noreply.github.com>

fix(orchestrator): address late review findings

452d3d5

Co-authored-by: codex <codex@users.noreply.github.com>

fix(orchestrator): handle fresh review edge cases

7709348

Co-authored-by: codex <codex@users.noreply.github.com>

fix(orchestrator): harden provider edge cases

8dc3ad5

Co-authored-by: codex <codex@users.noreply.github.com>

fix(orchestrator): execute resolved runtime responses

0f87bec

Co-authored-by: codex <codex@users.noreply.github.com>

fix(orchestrator): release stranded effect claims

b54f3f8

Co-authored-by: codex <codex@users.noreply.github.com>

fix(worktrees): make handoff rollback atomic

217b557

Co-authored-by: codex <codex@users.noreply.github.com>

fix(orchestrator): avoid replaying settled effects

3e27eca

Co-authored-by: codex <codex@users.noreply.github.com>

fix(orchestrator): preserve retryable effect failures

20b1a48

Co-authored-by: codex <codex@users.noreply.github.com>

fix(orchestrator): preserve terminal effect outcomes

873aff9

Co-authored-by: codex <codex@users.noreply.github.com>

juliusmarminge added 12 commits September 7, 2026 23:12

feat(mcp): expose scheduled task run-now (pingdotgg#10562)

e060fec

feat(mcp): expose project service operations (pingdotgg#10563)

e64c1bb

feat(mcp): expose attachment upload and send (pingdotgg#10564)

892c468

feat(mcp): expose project thread launch service (pingdotgg#10565)

cc2a95e

feat(mcp): expose branch-backed workspace discovery (pingdotgg#10566)

054a37d

fix(orchestration): map late steering to follow-up turns

a6bbe8b

- Re-route steering that races completion into idempotent follow-up dispatches - Preserve scheduled-task attribution and provider ownership history across clients

chore: remove accidentally committed audit artifacts

5b42579

fix(web): port auto-balance updates to v2 chat

8ca7ee3

Keep main's batch machine-update banner and update action while preserving the v2 runtime-based environment lock used by draft load balancing.

chore: format files exposed by CI

2460494

juliusmarminge force-pushed the t3code/codex-turn-mapping branch from efd9994 to 6102d00 Compare September 8, 2026 06:23

juliusmarminge and others added 7 commits September 8, 2026 14:26

fix(web): restore compact load-earlier control

91b1936

fix(web): preserve tool failures after output redaction

7dd9873

test(server): match V2 tool output redaction in retention coverage

2088c00

fix(server): reconcile historical V2 migration manifests

765313a

fix(server): reconcile historical V2 ledgers to the current migration…

835bf8a

… IDs

saphid force-pushed the fix/v2-historical-migrations-20260905 branch from 718bc3f to 835bf8a Compare September 9, 2026 00:41

macroscopeapp Bot reviewed Sep 9, 2026

View reviewed changes

juliusmarminge and others added 3 commits September 8, 2026 19:08

fix(server): consolidate V2 migrations and refine runtime recovery

fdfadf3

Merge commit 'fdfadf3d066622dfaacf2726ee3e2fad450e5a5d' into HEAD

13adf6f

fix(server): consolidate historical V2 ledgers without replaying schema

9e39290

github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Sep 9, 2026

saphid mentioned this pull request Sep 9, 2026

fix(orchestrator): preserve task-step elapsed time across restart #10051

Draft

juliusmarminge force-pushed the t3code/codex-turn-mapping branch from 8187b17 to ada72ce Compare September 9, 2026 06:39

Navigation Menu

Uh oh!

fix(server): reconcile historical V2 migration manifests - #9900

fix(server): reconcile historical V2 migration manifests#9900
saphid wants to merge 389 commits into
pingdotgg:t3code/codex-turn-mappingfrom
saphid:fix/v2-historical-migrations-20260905

saphid commented Sep 5, 2026 •

edited

Loading

Uh oh!

macroscopeapp Bot commented Sep 5, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Sep 7, 2026

Uh oh!

macroscopeapp Bot left a comment

Uh oh!

macroscopeapp Bot commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

saphid commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

macroscopeapp Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

cursor Bot commented Sep 7, 2026

Bugbot is paused — on-demand spend limit reached

Uh oh!

macroscopeapp Bot left a comment

Choose a reason for hiding this comment

Uh oh!

macroscopeapp Bot commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

saphid commented Sep 5, 2026 •

edited

Loading

macroscopeapp Bot commented Sep 5, 2026 •

edited

Loading