test(web): cancel queued animation frames during worker cleanup - #10880
Open
saphid wants to merge 2 commits into
Open
test(web): cancel queued animation frames during worker cleanup#10880saphid wants to merge 2 commits into
saphid wants to merge 2 commits into
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Both changed files are isolated test code: one updates a retention assertion, and the other cleans up mocked animation-frame callbacks during teardown. No production behavior, product defaults, or static-analysis configuration is changed. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Contributor
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
macroscopeapp
Bot
dismissed
their stale review
September 9, 2026 03:49
Dismissing prior approval to re-evaluate 52c3fcb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The editable-file language test can leave a worker statistics animation frame queued after teardown removes the browser globals. CI then reports an uncaught
cancelAnimationFrame is not definederror even when every assertion passes.Track the test-owned animation frame handles and cancel the remaining callbacks after worker termination and highlighter disposal, before restoring globals. Production behavior is unchanged. This is a prerequisite for #10051. It includes the existing test-only retention correction from #10865 because the current V2 base otherwise fails that server assertion; merge #10865 first. The incremental cleanup remains one web test file.
Verification: all 7 tests in
fileEditorLanguageReadiness.test.tspassed with the fix; focused lint and formatting passed. The identical patch was tested in the #10051 composition. A recent directclaude -p --model claude-opus-5 --effort high --tools '' --output-format jsonreview attempt exited 1 because OAuth had expired, before inference; independent review was unavailable.Model: GPT-6 Astra. Harness: Codex (T3 Code).