fix(web): clone destination picker no longer clips folders behind its footer - #10844
fix(web): clone destination picker no longer clips folders behind its footer#10844tan7vir wants to merge 1 commit into
Conversation
…ve the footer The clone confirm step stacks a fixed Repository block above the directory list inside a panel that is not a flex column, so the list kept the full panel height, started below that block, and its bottom rows were clipped behind the footer. The last folder could never be scrolled into view. The panel is now a constrained flex column with the Repository chrome pinned, so the list shrinks to the remaining space and every row scrolls fully above the footer. Fixes pingdotgg#10829. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, isolated command-palette layout correction that keeps the repository context fixed while allowing the existing results list to use the available height. It changes presentation only and introduces no new capability, data contract, configuration default, or production workflow. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe command palette panel now uses a constrained flex-column layout. The remote repository context header keeps its intrinsic height. ChangesCommand palette layout
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The clone destination picker now reserves space for its footer so lower directory entries can scroll fully into view. The change is limited to palette layout styling, with no remaining merge-readiness risk identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
What Changed
The clone confirm step of the command palette (Add project → Git URL / GitHub repository → choose destination) now scrolls every directory row fully above the Navigate / Select / Back / Close footer.
Two class changes in
apps/web/src/components/CommandPalette.tsx: the palette panel becomes a constrained flex column (flex min-h-0 flex-col, keeping its existing max-height), and the fixed Repository block above the list isshrink-0.Why
Fixes #10829.
CommandPanelisoverflow-hiddenbut not a flex column, and the directory list'sScrollArearoot issize-full. On the clone confirm step the non-scrolling Repository block sits above that list, so the list still measured the full panel height but started 84px lower. Its bottom 84px were clipped by the panel, directly behind the footer, and the last directory could never be scrolled into view. Measured at 1280×820: with the list scrolled to the end, the last row sat at y=505–537 while the panel ended at 461.With the panel as a flex column the list shrinks to the remaining space: the scroll viewport now ends exactly at the footer's top edge and the last row lands at 421–453, fully visible. This is the pattern the content search palette already uses (
panelClassName="flex min-h-0 flex-1 flex-col") and matches the fix suggested in the issue triage.Checked for regressions in the plain palette and in Add project → Local folder browse mode: with no Repository block the list still fills the panel and scrolls as before.
Verification:
vp lint(only pre-existing warnings on untouched lines),vp fmt --check, andvp run --filter @t3tools/web typecheckpass.UI Changes
Destination picker with the list scrolled to the end, 1280×820. In the before image the bottom rows are cut off under the footer; after, the last folder (
wp-wt-60281) is fully visible above it.Full-window captures: before · after.
Checklist
Written by Claude Fable 5.1 in Claude Code.
Summary by CodeRabbit