Skip to content

fix(web): clone destination picker no longer clips folders behind its footer - #10844

Open
tan7vir wants to merge 1 commit into
pingdotgg:mainfrom
tan7vir:fix/clone-destination-picker-clipping
Open

fix(web): clone destination picker no longer clips folders behind its footer#10844
tan7vir wants to merge 1 commit into
pingdotgg:mainfrom
tan7vir:fix/clone-destination-picker-clipping

Conversation

@tan7vir

@tan7vir tan7vir commented Sep 8, 2026

Copy link
Copy Markdown

What Changed

The clone confirm step of the command palette (Add project → Git URL / GitHub repository → choose destination) now scrolls every directory row fully above the Navigate / Select / Back / Close footer.

Two class changes in apps/web/src/components/CommandPalette.tsx: the palette panel becomes a constrained flex column (flex min-h-0 flex-col, keeping its existing max-height), and the fixed Repository block above the list is shrink-0.

Why

Fixes #10829.

CommandPanel is overflow-hidden but not a flex column, and the directory list's ScrollArea root is size-full. On the clone confirm step the non-scrolling Repository block sits above that list, so the list still measured the full panel height but started 84px lower. Its bottom 84px were clipped by the panel, directly behind the footer, and the last directory could never be scrolled into view. Measured at 1280×820: with the list scrolled to the end, the last row sat at y=505–537 while the panel ended at 461.

With the panel as a flex column the list shrinks to the remaining space: the scroll viewport now ends exactly at the footer's top edge and the last row lands at 421–453, fully visible. This is the pattern the content search palette already uses (panelClassName="flex min-h-0 flex-1 flex-col") and matches the fix suggested in the issue triage.

Checked for regressions in the plain palette and in Add project → Local folder browse mode: with no Repository block the list still fills the panel and scrolls as before.

Verification: vp lint (only pre-existing warnings on untouched lines), vp fmt --check, and vp run --filter @t3tools/web typecheck pass.

UI Changes

Destination picker with the list scrolled to the end, 1280×820. In the before image the bottom rows are cut off under the footer; after, the last folder (wp-wt-60281) is fully visible above it.

Before After
Before: last rows clipped behind the footer After: last row scrolls fully above the footer

Full-window captures: before · after.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes (not applicable: no motion or interaction change)

Written by Claude Fable 5.1 in Claude Code.

Summary by CodeRabbit

  • Bug Fixes
    • Improved command palette layout behavior to better constrain panel height and preserve the remote repository context header’s visibility.

…ve the footer

The clone confirm step stacks a fixed Repository block above the directory
list inside a panel that is not a flex column, so the list kept the full
panel height, started below that block, and its bottom rows were clipped
behind the footer. The last folder could never be scrolled into view.

The panel is now a constrained flex column with the Repository chrome
pinned, so the list shrinks to the remaining space and every row scrolls
fully above the footer. Fixes pingdotgg#10829.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 8, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at d4fa8ce

Macroscope's review found this PR approvable — This is a small, isolated command-palette layout correction that keeps the repository context fixed while allowing the existing results list to use the available height. It changes presentation only and introduces no new capability, data contract, configuration default, or production workflow.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 11743336-d1d3-471f-b6a0-1d9db34368d5

📥 Commits

Reviewing files that changed from the base of the PR and between 7fbc545 and d4fa8ce.

📒 Files selected for processing (1)
  • apps/web/src/components/CommandPalette.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The command palette panel now uses a constrained flex-column layout. The remote repository context header keeps its intrinsic height.

Changes

Command palette layout

Layer / File(s) Summary
Panel sizing and header preservation
apps/web/src/components/CommandPalette.tsx
The panel uses flex-column sizing with min-h-0. The remote repository context block uses shrink-0.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to d4fa8

The clone destination picker now reserves space for its footer so lower directory entries can scroll fully into view. The change is limited to palette layout styling, with no remaining merge-readiness risk identified.

Suggested reviewers: t3dotgg, maria-rcks, juliusmarminge

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary fix: preventing folders in the clone destination picker from being clipped behind the footer.
Description check ✅ Passed The description includes the required What Changed, Why, UI Changes, and Checklist sections. It explains the cause, solution, verification, and UI result, with before/after screenshots.
Linked Issues check ✅ Passed The flex-column and non-shrinking Repository block changes directly address issue #10829 by allowing directory rows to scroll fully above the footer. The description also reports preserved behavior in…
Out of Scope Changes check ✅ Passed The changes are limited to two presentational class updates in CommandPalette.tsx and remain within the linked issue's clone destination picker scope.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Clone destination picker clips directory rows behind its footer

1 participant