fix(server): wait for native Codex start before Stop by saphid · Pull Request #10024 · pingdotgg/t3code

saphid · 2026-09-05T08:10:25Z

Stop now waits for native Codex turn/started when turn/start acknowledges a queued turn with a null start timestamp. If the turn terminates first, Stop settles without sending an invalid interrupt. This prevents the early Stop race that returned no active turn to interrupt.

Current head f2b6ea772 includes current V2 base 7dd9873ed and the shared test-only prerequisite #10865. Merge #10865 first; the topic itself changes 2 files. This rebuild removes the obsolete merged-base history from the PR diff.

Validation: 95 focused tests pass across the affected feature and foundation persistence coverage. Scoped server typecheck passes; targeted lint, formatting and diff checks pass. New-head CI is pending.

Earlier live-provider adapter probes reproduced the original issue and verified the feature patch on combined candidate fa6a1ab04. Those are historical adapter evidence, not fresh rendered-client or live-provider verification of this rebuilt head.

Independent cross-provider review was unavailable: the direct Claude Opus 5 high launcher in this audit exited 1 with expired OAuth before inference. No Claude review is claimed.

Targets Orchestrator V2 in #2829. Updated with GPT-6 in Codex/T3.

macroscopeapp · 2026-09-05T08:13:06Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This is a focused Codex race-condition fix with strong replay-test coverage and no schema, default, security, or deployment changes. The Stop path now waits without a timeout for native start or terminalization, so a human should assess the impact of a missing signal before merge.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 2791e93

macroscopeapp · 2026-09-08T06:00:10Z

Macroscope has since reviewed this pull request. An earlier review was skipped by a cost limit; a review has now completed, so that notice no longer applies.

Allow merge-back from provider-finished runs awaiting checkpoint capture while keeping waiting runs visible but non-interruptible in mobile. Co-authored-by: codex <codex@users.noreply.github.com>

Co-authored-by: codex <codex@users.noreply.github.com>

- Re-route steering that races completion into idempotent follow-up dispatches - Preserve scheduled-task attribution and provider ownership history across clients

Port main's pull-request discovery, active thread ordering, async question dismissal, settlement fixes, provider-session import, attachment context, and provider correctness changes into orchestration v2. Keep the branch's intentional composer and subagent behavior while adopting main's web and mobile fixes. Prevent headless setup terminals from hanging on the color probe, and move the v2 migration block to 050-061 after main claimed 048-049.

Restore the failed-before-start timer guard, align two server fixtures with the reconciled behavior, and remove dead files, exports, and dependencies surfaced by Knip. Drop the temporary branch push trigger now that the PR is mergeable, so each update runs the pull-request workflow once.

Keep main's batch machine-update banner and update action while preserving the v2 runtime-based environment lock used by draft load balancing.

Adopt TypeScript 7 and Effect rc.112 across orchestration v2, including the TaggedError API migration and updated Effect-aware tests. Restore main's composer-aware scroll-to-end clearance while retaining selected-model settings sync, preview recording transfer, image galleries, desktop context menus, and layout hit targets. Regenerate the lockfile on the upgraded dependency baseline.

Advertise bounded socket snapshots and authoritative dispatch validation, omit raw command output and inline file bodies at the wire boundary, and preserve compact status metadata across web and mobile. Add transport-budget coverage for snapshots, resume, commands, legacy import, and projection maintenance.

macroscopeapp

All clear

^{Posted via Macroscope — Effect Service Conventions}

macroscopeapp · 2026-09-09T00:09:18Z

All clear

^{Posted via Macroscope — Effect Service Conventions}

github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 5, 2026

macroscopeapp Bot previously approved these changes Sep 5, 2026

View reviewed changes

saphid added a commit to saphid/t3code that referenced this pull request Sep 7, 2026

merge(v2): refresh pingdotgg#10024 onto current target

da99a64

juliusmarminge force-pushed the t3code/codex-turn-mapping branch 2 times, most recently from 9242b91 to 3d81172 Compare September 8, 2026 03:31

github-actions Bot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels Sep 8, 2026

juliusmarminge and others added 19 commits September 7, 2026 23:12

fix(orchestration): handle checkpoint-wait runs

e8f6978

Allow merge-back from provider-finished runs awaiting checkpoint capture while keeping waiting runs visible but non-interruptible in mobile. Co-authored-by: codex <codex@users.noreply.github.com>

fix(orchestration): cancel queued work on archive

5595930

Co-authored-by: codex <codex@users.noreply.github.com>

fix(mobile): allow archiving post-provider work

e0f89c5

Co-authored-by: codex <codex@users.noreply.github.com>

fix(mobile): distinguish queued and waiting archive states

2e776a8

Co-authored-by: codex <codex@users.noreply.github.com>

fix(cursor): log close attempts before execution

e6d5c09

Co-authored-by: codex <codex@users.noreply.github.com>

fix(acp): discover final teardown descendants

b13443d

Co-authored-by: codex <codex@users.noreply.github.com>

fix(checkpoints): preserve valid run history

03d044b

Co-authored-by: codex <codex@users.noreply.github.com>

fix(orchestration): preserve imported conversation state

3c658ad

Co-authored-by: codex <codex@users.noreply.github.com>

fix(acp): enforce task and permission invariants

c252769

Co-authored-by: codex <codex@users.noreply.github.com>

fix(testkit): harden provider replay recording

5941af5

Co-authored-by: codex <codex@users.noreply.github.com>

fix(server): isolate deterministic attachment ids

3d4a365

Co-authored-by: codex <codex@users.noreply.github.com>

fix(claude): preserve explicit model options

e596525

Co-authored-by: codex <codex@users.noreply.github.com>

fix(web): enforce secure provider field defaults

eb63d51

Co-authored-by: codex <codex@users.noreply.github.com>

fix(client): preserve live thread relationships

3cbe7fb

Co-authored-by: codex <codex@users.noreply.github.com>

fix(checkpoints): retain thread-start baseline after failed runs

12fbe64

Co-authored-by: codex <codex@users.noreply.github.com>

fix(mobile): gate thread controls on live runs

4ce4c48

Co-authored-by: codex <codex@users.noreply.github.com>

fix(orchestrator): address late review findings

452d3d5

Co-authored-by: codex <codex@users.noreply.github.com>

fix(orchestrator): handle fresh review edge cases

7709348

Co-authored-by: codex <codex@users.noreply.github.com>

fix(orchestrator): harden provider edge cases

8dc3ad5

Co-authored-by: codex <codex@users.noreply.github.com>

juliusmarminge added 16 commits September 7, 2026 23:12

feat(mcp): expose fork and merge-back commands (pingdotgg#10558)

26eae29

feat(mcp): expose preview list and close (pingdotgg#10559)

120a156

feat(mcp): expose selected environment preferences (pingdotgg#10560)

d5f853a

feat(mcp): expose the existing thread search query (pingdotgg#10561)

90335b9

feat(mcp): expose scheduled task run-now (pingdotgg#10562)

e060fec

feat(mcp): expose project service operations (pingdotgg#10563)

e64c1bb

feat(mcp): expose attachment upload and send (pingdotgg#10564)

892c468

feat(mcp): expose project thread launch service (pingdotgg#10565)

cc2a95e

feat(mcp): expose branch-backed workspace discovery (pingdotgg#10566)

054a37d

fix(orchestration): map late steering to follow-up turns

a6bbe8b

- Re-route steering that races completion into idempotent follow-up dispatches - Preserve scheduled-task attribution and provider ownership history across clients

chore: remove accidentally committed audit artifacts

5b42579

fix(web): port auto-balance updates to v2 chat

8ca7ee3

Keep main's batch machine-update banner and update action while preserving the v2 runtime-based environment lock used by draft load balancing.

chore: format files exposed by CI

2460494

juliusmarminge force-pushed the t3code/codex-turn-mapping branch from efd9994 to 6102d00 Compare September 8, 2026 06:23

juliusmarminge and others added 4 commits September 8, 2026 14:26

fix(web): restore compact load-earlier control

91b1936

fix(server): wait for native Codex start before Stop

b81d04e

fix(web): preserve tool failures after output redaction

7dd9873

saphid force-pushed the fix/v2-codex-queued-stop-20260905 branch from 2791e93 to b81d04e Compare September 9, 2026 00:06

github-actions Bot added size:S 10-29 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Sep 9, 2026

macroscopeapp Bot reviewed Sep 9, 2026

View reviewed changes

test(server): match V2 tool output redaction in retention coverage

2088c00

saphid mentioned this pull request Sep 9, 2026

test(server): match V2 tool output redaction in retention coverage #10865

Open

Merge commit '2088c001d' into HEAD

f2b6ea7

juliusmarminge force-pushed the t3code/codex-turn-mapping branch from 8187b17 to ada72ce Compare September 9, 2026 06:39

Navigation Menu

Uh oh!

fix(server): wait for native Codex start before Stop - #10024

fix(server): wait for native Codex start before Stop#10024
saphid wants to merge 385 commits into
pingdotgg:t3code/codex-turn-mappingfrom
saphid:fix/v2-codex-queued-stop-20260905

saphid commented Sep 5, 2026 •

edited

Loading

Uh oh!

macroscopeapp Bot commented Sep 5, 2026 •

edited

Loading

Uh oh!

macroscopeapp Bot commented Sep 8, 2026 •

edited

Loading

Uh oh!

macroscopeapp Bot left a comment

Uh oh!

macroscopeapp Bot commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

saphid commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

macroscopeapp Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

macroscopeapp Bot commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

macroscopeapp Bot left a comment

Choose a reason for hiding this comment

Uh oh!

macroscopeapp Bot commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

saphid commented Sep 5, 2026 •

edited

Loading

macroscopeapp Bot commented Sep 5, 2026 •

edited

Loading

macroscopeapp Bot commented Sep 8, 2026 •

edited

Loading