Test on PHP 8.4/8.5 and run lowest deps on every PHP version - #45
Open
snapshotpl wants to merge 1 commit into
Open
Test on PHP 8.4/8.5 and run lowest deps on every PHP version#45snapshotpl wants to merge 1 commit into
snapshotpl wants to merge 1 commit into
Conversation
Extend the CI matrix to PHP 8.0-8.5 with both highest and lowest dependency resolution, and drop the lowest-job excludes by pinning require-dev floors to releases that run on the whole range: - phpunit ^9.6.19, vfsstream ^1.6.12, var-dumper ^5.4.48 - laminas-diactoros ^2.18.1 || ^3.0 (2.x tops out at PHP 8.3) - slim/slim ^3 -> ^4.15.2: Slim 3 cannot cover the matrix (3.12.5 leaks deprecations into the output buffer on 8.1+ and makes App::run() throw, 3.13.0 requires PHP ^8.1), so the framework test now boots a Slim 4 App Slim 3 stays supported at runtime: extractPath() duck-types the Slim\Http\Uri::getBasePath() quirk via method_exists instead of instanceof, so PHPStan no longer needs the class, and the branch is covered by a new unit test with SlimUriStub. Verified in docker: lowest on 8.0/8.4/8.5, highest on 8.5, and PHPStan level 6 on 8.0 are all green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QCFRdzoTxAMkVqfBK13Z4U
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
highestandlowestdependency resolution, and removes thelowestexcludes for 8.1–8.3.lowestjobs pass everywhere by pinningrequire-devfloors to releases that run on the whole 8.0–8.5 range:phpunit ^9.6.19,vfsstream ^1.6.12,var-dumper ^5.4.48,laminas-diactoros ^2.18.1 || ^3.0(2.x tops out at PHP 8.3, so 8.4/8.5 resolve to 3.x). Packages with upper-bounded per-releasephpconstraints (laminas, mezzio) resolve per platform on their own and needed no changes.^4.15.2, supports PHP 7.4–8.5). Slim 3 cannot cover the matrix: 3.12.5 emits deprecations on PHP 8.1+ that land in the output buffer and makeApp::run()throwUnexpected data in output buffer, while 3.13.0 requires PHP^8.1and would exclude the 8.0 jobs.extractPath()now duck-types theSlim\Http\Uri::getBasePath()quirk viamethod_existsinstead ofinstanceof, so PHPStan no longer needs the class fromslim/slim3. The branch is covered by a new unit test usingSlimUriStub; the double-pass__invoke()path was already covered bytestTwoPassCallingForCompatibility.Test plan
Verified locally in Docker (
php:X.Y-cli+ composer):--prefer-lowest— OK (31 tests, 80 assertions)--prefer-lowest— OK--prefer-lowest— OKsrc/(PHP 8.0, highest) — no errorsNote: on PHP 8.4/8.5
lowest,maximebf/debugbar1.19 prints one harmless implicit-nullable deprecation (DebugBar::setStorage()); fixing that would require raising the productionrequirefloor, so it is left as-is.🤖 Generated with Claude Code
https://claude.ai/code/session_01QCFRdzoTxAMkVqfBK13Z4U