fix(features): the last two struct-drift selections — depth_slice and stream_options - #3265
Merged
Merged
Conversation
`wgpu::RenderPassColorAttachment` gained `depth_slice`, for rendering into one slice of a 3D texture. The `view` here is a 2D surface texture, for which `None` is the only valid value. This is the ONLY `RenderPassColorAttachment` in the workspace, so there was no sibling initializer to copy from — and nothing builds this crate with `gpu`, so no gate ever saw the field go missing. Found by the 430-pair (crate, feature) sweep (#3262). `aprender-present-lib --no-default-features --features gpu` checks clean. Pmat-Ticket: PMAT-1098 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
… complexity violations `jugar_probar::llm::ChatRequest` grew `stream_options` and this initializer was never updated, because nothing builds `aprender-test-cli --features llm`. Its own doc settles the value: it "must be absent when `stream` is not `true`" because OpenAI rejects it outright on a non-streaming request, and this call site sets `stream: Some(false)`. So `None`, not a copy of what `wire_request` sends on the streaming path. Found by the 430-pair (crate, feature) sweep (#3262). The one-line fix was blocked by the pre-commit complexity gate on SIX PRE-EXISTING violations in the same file, none of them in code this change wrote. Paid down here, as the gate requires — all behaviour-preserving: execute_llm_load cyc 36 / cog 61 -> under execute_llm_score cyc 40 / cog 91 -> under execute_llm_sweep cog 40 -> under execute_llm_experiment cog 36 -> under render_card every `--by-*` section of execute_llm_score repeated the same three-arm `match args.format` verbatim; only the two formatter fns differ, so they are passed in. NINE sites collapsed. print_load_summary ~140 lines of conditional reporting that decide nothing — they read `result` and print print_tail_analysis Feature 3 section print_quality_validation Feature 5 section health_gate GH-37's four outcomes, a nested match inside an else; each still names the endpoint and the bypass flag detect_saturation no baseline (the first level) is never saturated; the reason string is byte-identical level_status saturation still wins over zero-quality pareto_frontier a level that decodes nothing is not a faster configuration, it is a broken one — unchanged experiment_status the `status` match arm, whole `--features llm` and default both check clean, clippy finds nothing in this file, and aprender-test-cli --lib is 753/753 with all 10 of llm.rs's tests still present. Pmat-Ticket: PMAT-1098 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
noahgift
enabled auto-merge
September 14, 2026 12:08
|
§13.11 rung 1 — quorum shadow verdict Shadow mode: this records a verdict and merges nothing. A refusal |
noahgift
disabled auto-merge
September 14, 2026 17:42
noahgift
enabled auto-merge
September 14, 2026 18:38
This was referenced Sep 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The last two mechanical items from the 430-pair
(crate, feature)sweep (#3262). Both are struct drift: a field was added upstream and the one initializer in the tree was never updated, because no gate ever builds these selections.Noneis the right valuegpuwgpu::RenderPassColorAttachment::depth_sliceviewhere is a 2D surface texture, for whichNoneis the only valid value. This is the onlyRenderPassColorAttachmentin the workspace, so there was no sibling to copy.llmjugar_probar::llm::ChatRequest::stream_optionsstreamis nottrue" because OpenAI rejects it outright on a non-streaming request — and this call site setsstream: Some(false). SoNone, not a copy of whatwire_requestsends on the streaming path.With #3263 and this PR, every red pair in the matrix is fixed except the nine owned elsewhere: seven
aprender-distributeselections (#3257 — itstokiogate is right, butexecutor/cpu.rsalso usesnum_cpus, which only thecpufeature pulls; verified against that PR's head) and twocudaselections (#3179 — a driver-API decision).Complexity debt paid down
aprender-test-cli's one-line fix was blocked by the pre-commit complexity gate on six PRE-EXISTING violations in the same file, none in code this PR wrote. Paid down here, as the gate requires — all behaviour-preserving:The largest single win is
render_card: every--by-*section ofexecute_llm_scorerepeated the same three-armmatch args.formatverbatim and only the two formatter functions differed, so they are passed in — nine sites collapsed. The rest are block extractions:print_load_summary(~140 lines that decide nothing — they readresultand print),print_tail_analysis,print_quality_validation,health_gate(GH-37's four outcomes, each still naming the endpoint and the bypass flag),detect_saturation(no baseline ⇒ never saturated; the reason string is byte-identical),level_status(saturation still wins over zero-quality),pareto_frontier, andexperiment_status.Verified
cargo checkclean, and both crates' defaults cleanaprender-test-cli --lib753/753,aprender-present-lib --lib60/60 — and all 10 ofllm.rs's#[test]are still present, checked explicitly rather than inferred from the totalllm.rs; the fiveunwrap()warnings in this crate are pre-existing and in files this PR never touches (comply, load_testing, statistics, stress)unwrap()added:git diff | grep '^+.*\.unwrap()'is 0no-close: #3262 is the umbrella measurement and stays open until the last nine pairs are green; #3257 and #3179 are owned elsewhere.
🤖 Generated with Claude Code