Add NativeAOT support - #1
Merged
Merged
Conversation
Use a source-generated TomlSerializerContext for the internal TomlTable deserialization instead of the reflection-based overload. Reflection-based TOML serialization is disabled by default under PublishAot=true, which made the previous call fail at runtime and emit IL2026/IL3050 warnings. - Add internal TomlModelSerializerContext with [TomlSerializable(typeof(TomlTable))] - Parse via TomlSerializer.Deserialize<TomlTable>(text, context) - Mark the library IsAotCompatible and bump Tomlyn to 2.10.1 - Add a NativeAOT smoke-test project and CI workflow (test + AOT publish/run)
pableess
marked this pull request as ready for review
September 14, 2026 03:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the library NativeAOT/trim compatible. Fixes the one reflection-based code path and declares AOT support.
Problem
TomlConfigurationFileParsercalled the reflection-basedTomlSerializer.Deserialize<TomlTable>(string)overload, which is annotated[RequiresUnreferencedCode]/[RequiresDynamicCode]. Tomlyn disables reflection-based serialization by default whenPublishAot=true, so this would emit IL2026/IL3050 warnings and fail at runtime on NativeAOT.Changes
TomlModelSerializerContextwith[TomlSerializable(typeof(TomlTable))].TomlSerializer.Deserialize<TomlTable>(text, TomlModelSerializerContext.Default).<IsAotCompatible>true</IsAotCompatible>and bump Tomlyn to 2.10.1.Tomlyn.Extensions.Configuration.AotTests) that exercisesAddTomlFile,AddTomlStreamandRemoveUnderscores.-r linux-x64.IConfiguration.Bind).Verification
dotnet build(Release, all TFMs): no IL2026/IL3050 warnings.dotnet test(net10.0): passing.dotnet publish -p:PublishTrimmed=true -r linux-x64+ run: passing (no clang available locally for the full AOT compile; CI installs clang and performs the actual NativeAOT publish/run).