Skip to content
This repository was archived by the owner on Aug 23, 2026. It is now read-only.

feat: add Terminal API and Custom Resource Definition for interactive… - #146

Draft
iasthc wants to merge 1 commit into
mainfrom
console-api
Draft

feat: add Terminal API and Custom Resource Definition for interactive…#146
iasthc wants to merge 1 commit into
mainfrom
console-api

Conversation

@iasthc

@iasthc iasthc commented Aug 19, 2026

Copy link
Copy Markdown
Member

This pull request introduces a new "Terminal" custom resource definition (CRD) to support user-interactive kubectl session pods managed by the console operator. It adds the API schema, Go type definitions, and registers the resource with the Kubernetes API machinery. The changes also update documentation and kustomization to include the new CRD.

Introduction of Terminal CRD and supporting code:

  • Adds a new CRD manifest for Terminal resources in config/crd/bases/console.otterscale.io_terminals.yaml, defining the schema, validation rules, status fields, and additional printer columns for kubectl output.
  • Updates config/crd/kustomization.yaml to include the new Terminal CRD in the kustomize build.

Go API types and registration:

  • Implements Go type definitions for the Terminal resource, including Terminal, TerminalList, TerminalSpec, TerminalStatus, and supporting types in console/v1alpha1/terminal_types.go. These types capture the CRD schema and validation logic.
  • Registers the Terminal resource types with the Kubernetes API machinery in console/v1alpha1/groupversion_info.go, enabling the controller to work with these resources.

Documentation:

  • Updates the README.md to document the new Terminal resource, its group, scope, and purpose in the CRD table.… kubectl sessions

Copilot AI lite review requested due to automatic review settings August 19, 2026 09:47
@iasthc
iasthc marked this pull request as draft August 19, 2026 09:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new Terminal Custom Resource Definition (CRD) under console.otterscale.io/v1alpha1, along with the corresponding Go API types and scheme registration so other components (e.g., the console operator) can create/read/update these resources and generate CRD manifests.

Changes:

  • Adds the Terminal CRD manifest (schema, validation rules, printer columns, and status subresource).
  • Adds console/v1alpha1 Go API types (including spec/status) plus generated deepcopy code and scheme registration.
  • Updates CRD kustomization and README to include/document the new resource.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
README.md Documents the new Terminal CRD in the repository’s CRD table.
console/v1alpha1/zz_generated.deepcopy.go Adds controller-gen generated deepcopy implementations for the new Terminal API types.
console/v1alpha1/terminal_types.go Defines the Terminal Go types, validation markers, printer columns, and status subresource markers.
console/v1alpha1/groupversion_info.go Registers Terminal and TerminalList with the Kubernetes scheme for console.otterscale.io/v1alpha1.
config/crd/kustomization.yaml Includes the new Terminal CRD in the CRD kustomize package.
config/crd/bases/console.otterscale.io_terminals.yaml Adds the generated CRD manifest for Terminal resources.
Files not reviewed (1)
  • console/v1alpha1/zz_generated.deepcopy.go: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants