This repository was archived by the owner on Aug 23, 2026. It is now read-only.
feat: add Terminal API and Custom Resource Definition for interactive… - #146
Draft
iasthc wants to merge 1 commit into
Draft
feat: add Terminal API and Custom Resource Definition for interactive…#146iasthc wants to merge 1 commit into
iasthc wants to merge 1 commit into
Conversation
… kubectl sessions
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Terminal Custom Resource Definition (CRD) under console.otterscale.io/v1alpha1, along with the corresponding Go API types and scheme registration so other components (e.g., the console operator) can create/read/update these resources and generate CRD manifests.
Changes:
- Adds the
TerminalCRD manifest (schema, validation rules, printer columns, and status subresource). - Adds
console/v1alpha1Go API types (including spec/status) plus generated deepcopy code and scheme registration. - Updates CRD kustomization and README to include/document the new resource.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents the new Terminal CRD in the repository’s CRD table. |
| console/v1alpha1/zz_generated.deepcopy.go | Adds controller-gen generated deepcopy implementations for the new Terminal API types. |
| console/v1alpha1/terminal_types.go | Defines the Terminal Go types, validation markers, printer columns, and status subresource markers. |
| console/v1alpha1/groupversion_info.go | Registers Terminal and TerminalList with the Kubernetes scheme for console.otterscale.io/v1alpha1. |
| config/crd/kustomization.yaml | Includes the new Terminal CRD in the CRD kustomize package. |
| config/crd/bases/console.otterscale.io_terminals.yaml | Adds the generated CRD manifest for Terminal resources. |
Files not reviewed (1)
- console/v1alpha1/zz_generated.deepcopy.go: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new "Terminal" custom resource definition (CRD) to support user-interactive kubectl session pods managed by the console operator. It adds the API schema, Go type definitions, and registers the resource with the Kubernetes API machinery. The changes also update documentation and kustomization to include the new CRD.
Introduction of Terminal CRD and supporting code:
Terminalresources inconfig/crd/bases/console.otterscale.io_terminals.yaml, defining the schema, validation rules, status fields, and additional printer columns for kubectl output.config/crd/kustomization.yamlto include the new Terminal CRD in the kustomize build.Go API types and registration:
Terminal,TerminalList,TerminalSpec,TerminalStatus, and supporting types inconsole/v1alpha1/terminal_types.go. These types capture the CRD schema and validation logic.console/v1alpha1/groupversion_info.go, enabling the controller to work with these resources.Documentation:
README.mdto document the newTerminalresource, its group, scope, and purpose in the CRD table.… kubectl sessions