Skip to content

OCPNETUI-65: Fix formatting before eslint/prettier version bump - #515

Closed
rszwajko wants to merge 1 commit into
openshift:mainfrom
rszwajko:fixLintBeforeEslintBump
Closed

rszwajko wants to merge 1 commit into
openshift:mainfrom
rszwajko:fixLintBeforeEslintBump

Conversation

@rszwajko

@rszwajko rszwajko commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Unblocks #501

Summary by CodeRabbit

  • Style
    • Reformatted internal type and component code for improved readability.
    • No user-facing behavior or functionality changes.

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 15, 2026
@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot

openshift-ci-robot commented Sep 15, 2026

Copy link
Copy Markdown

@rszwajko: This pull request references OCPNETUI-65 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 76d2ab21-f596-4e27-932e-c2560a9334b1

📥 Commits

Reviewing files that changed from the base of the PR and between a009228 and fbafb7f.

📒 Files selected for processing (2)
  • src/utils/components/Area/utils/types.ts
  • src/views/networkpolicies/new/components/NetworkPolicySelectorPreview/components/NetworkPolicyPodsPreview.tsx

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting


Walkthrough

The pull request reformats a type union and a .map() callback. The changes do not alter type behavior, mapping behavior, returned fields, or public declarations.

Changes

Formatting cleanup

Layer / File(s) Summary
Type and callback formatting
src/utils/components/Area/utils/types.ts, src/views/networkpolicies/new/components/NetworkPolicySelectorPreview/components/NetworkPolicyPodsPreview.tsx
The ValueOrAccessor union and podTreeEntries mapping callback are condensed without functional changes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: parthivk100

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from metalice and pcbailey September 15, 2026 10:34
@rszwajko
rszwajko requested review from lkladnit and removed request for metalice and pcbailey September 15, 2026 10:34
@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rszwajko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2026
@rszwajko
rszwajko requested a review from pcbailey September 15, 2026 10:35
@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@rszwajko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint fbafb7f link true /test lint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rszwajko

Copy link
Copy Markdown
Contributor Author

The change needs to be done in the same PR as the eslint bump #501

@rszwajko rszwajko closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants