HYPERFLEET-1490 - feat: add hyperfleet.resource_id span attribute to service layer

[Ruclo]

Summary

• Set hyperfleet.resource_id and hyperfleet.resource_type span attributes on Get, Create, Patch, and Delete operations in pkg/services/resource.go
• Enables resource-level trace correlation in Tempo — operators can query traces by resource ID to find the API request that created or mutated a specific cluster or nodepool
• Add unit tests using tracetest.InMemoryExporter verifying span attributes are set for all 4 CRUD methods

Test plan

• make lint passes (0 issues)
• make test passes (1428 tests)
• 4 new span attribute tests pass (Get, Create, Patch, Delete)

🤖 Generated with Claude Code

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rh-amarin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8f5b751d-3657-4dc4-9752-e908f388c075

📥 Commits

Reviewing files that changed from the base of the PR and between abeabd3 and 99359c2.

📒 Files selected for processing (1)

• pkg/services/resource.go

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• openshift-hyperfleet/architecture (manual)
• openshift-hyperfleet/hyperfleet-api (manual)
• openshift-hyperfleet/hyperfleet-sentinel (manual)
• openshift-hyperfleet/hyperfleet-adapter (manual)
• openshift-hyperfleet/hyperfleet-broker (manual)

🚧 Files skipped from review as they are similar to previous changes (1)

• pkg/services/resource.go

---

📝 Walkthrough

Summary by CodeRabbit

• Observability

  • Resource operations now include resource IDs and types in OpenTelemetry traces, improving monitoring and troubleshooting.

• Tests

  • Expanded coverage to verify tracing attributes across resource retrieval, creation, updates, deletion, ownership queries, forced deletion, and adapter status processing.

Walkthrough

The resource service now records hyperfleet.resource_id and hyperfleet.resource_type on OpenTelemetry spans. Coverage includes creation, retrieval, update, deletion, owner lookup, adapter status processing, and force deletion. Tests use an in-memory exporter and cover successful and failed operations.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: sherine-k

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the resource span attribute change in the service layer.
Description check	✅ Passed	The description directly explains the span attributes, tracing purpose, affected operations, and test coverage.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output	✅ Passed	The non-test diff adds no slog/logger/logr/zap/fmt.Print* calls and no token, password, credential, or secret fields; existing logger fields are unchanged. CWE-532 is not triggered.
No Hardcoded Secrets	✅ Passed	The parent diff changes only Go tracing code and tests; it adds no API keys, tokens, passwords, private keys, embedded credentials, or long base64 configuration strings (CWE-798).
No Weak Cryptography	✅ Passed	The diff changes only resource tracing and tests; it adds OpenTelemetry imports and span attributes, with no banned primitives, custom cryptography, or secret comparisons.
No Injection Vectors	✅ Passed	The diff adds OpenTelemetry attributes and validation only. It adds no SQL construction, exec.Command, template.HTML, or yaml.Unmarshal; existing fmt.Sprintf query code is unchanged.
No Privileged Containers	✅ Passed	The diff changes only Go source and tests. No Kubernetes, Helm, or Dockerfile manifest changed. Existing USER root is unchanged and documented for package installation.
No Pii Or Sensitive Data In Logs	✅ Passed	The PR diff adds only OpenTelemetry span attributes and tests. It adds no slog, logr, zap, log, or fmt.Print logging, and no sensitive payload logging.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

✨ Simplify code

• Create PR with simplified code

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/services/resource_test.go`:
- Around line 3160-3163: Update the t.Cleanup callback around tp.Shutdown to
check and report its error, and ensure all four ForceFlush results are checked
and reported rather than ignored. Use the test’s existing error-reporting
mechanism so incomplete span export or shutdown failures fail the test.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 30542a9b-4b85-44d4-9812-6fa69da75e45

📥 Commits

Reviewing files that changed from the base of the PR and between cf39733 and 6117674.

📒 Files selected for processing (2)

• pkg/services/resource.go
• pkg/services/resource_test.go

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• openshift-hyperfleet/architecture (manual)
• openshift-hyperfleet/hyperfleet-api (manual)
• openshift-hyperfleet/hyperfleet-sentinel (manual)
• openshift-hyperfleet/hyperfleet-adapter (manual)
• openshift-hyperfleet/hyperfleet-broker (manual)

[hyperfleet-ci-bot]

Risk Score: 1 — risk/low

Signal	Detail	Points
PR size	268 lines (>200)	+1
Sensitive paths	none	+0
Test coverage	Tests cover changed packages	+0

_{Computed by hyperfleet-risk-scorer}

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[pnguyen44]

A few service methods aren't instrumented with these span attributes and would miss tracing coverage:

• GetByID — used by GET /resources/{id}, ForceDelete, ListStatuses, and CreateStatus
• ProcessAdapterStatus — used when adapters report status back to the API