fix: added inline commit lint - #39022
Merged
Merged
Conversation
Bump edx-lint to latest. This will need openedx#39022 to fast-follow to prevent failing checks. Commit generated by workflow `openedx/openedx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`
bmtcril
approved these changes
Aug 25, 2026
bmtcril
left a comment
bmtcril
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just noting that the edx-lint version bump commit was taken from a real run of the "upgrade-one-python-dependency" action. Included here since it needs to merge with these changes to prevent issues with lint checks failing.
robrap
reviewed
Aug 25, 2026
| ), | ||
| ) | ||
| # pylint: disable-next=pii-invalid-no-pii-annotation # field does not store user PII data, safe under OEP-30 | ||
| skip_email_verification = models.BooleanField( |
Contributor
There was a problem hiding this comment.
@Akanshu-2u: If it is simple, an enhancement to consider is to have the linter skip anything that is a BooleanField.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the upgrade of
edx-lintto the latest version,6.2.0, a new PII annotation check has been introduced. This may result in linter issues for both true positives and false positives.This PR addresses those issues by correcting the PII annotations for true positives and adding inline comments to suppress the linter for false positives.
Changes
no_piiannotations for models that contain PII fields.Relevant PR:
Private JIRA Link:
BOMS-587