Skip to content

feat: split read vs write authz checks for library updates - #39009

Open
wgu-taylor-payne wants to merge 1 commit into
openedx:masterfrom
WGU-Open-edX:tpayne/view-library-updates-permission
Open

feat: split read vs write authz checks for library updates#39009
wgu-taylor-payne wants to merge 1 commit into
openedx:masterfrom
WGU-Open-edX:tpayne/view-library-updates-permission

Conversation

@wgu-taylor-payne

Copy link
Copy Markdown
Contributor

Description

Updates the downstream sync v2 endpoints to use courses.view_library_updates for read access (list/summary) and courses.manage_library_updates for write access (sync/decline).

Previously, the list endpoint used has_studio_read_access (legacy only, no authz integration), and the sync/decline endpoints used has_studio_write_access. This meant Course Auditors were blocked from even viewing library update status. Per the design in openedx/openedx-authz#283, auditors should see the library updates page in read-only mode.

User roles impacted: Course Auditor — can now view (but not sync/decline) library updates when authz is enabled.

Changes:

  • cms/djangoapps/contentstore/rest_api/v2/views/downstreams.py:
    • DownstreamListView.get: Use COURSES_VIEW_LIBRARY_UPDATES for course-filtered requests
    • DownstreamSummaryView.get: Use COURSES_VIEW_LIBRARY_UPDATES instead of COURSES_VIEW_COURSE
    • _load_accessible_block: Use COURSES_MANAGE_LIBRARY_UPDATES for write, COURSES_VIEW_LIBRARY_UPDATES for read
    • Removed unused has_studio_read_access/has_studio_write_access imports
  • Tests: 5 new tests verifying editor can list+sync, auditor can list but not sync, unauthorized gets 403

Rollback: Gated behind AUTHZ_COURSE_AUTHORING_FLAG — disabling the flag triggers legacy fallback via user_has_course_permission.

Supporting information

Testing instructions

  1. Enable AUTHZ_COURSE_AUTHORING_FLAG for a course with library-linked components
  2. Assign a user the course_auditor role
  3. GET /api/contentstore/v2/downstreams/?course_id={course_id} → 200
  4. GET /api/contentstore/v2/downstreams/{course_id}/summary → 200
  5. POST /api/contentstore/v2/downstreams/{usage_key}/sync → 404 (permission denied)
  6. Assign course_editor → sync should succeed (200 or 400 depending on upstream state)
  7. User with no role → list returns 403

Deadline

None

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Aug 20, 2026
@openedx-webhooks

openedx-webhooks commented Aug 20, 2026

Copy link
Copy Markdown

Thanks for the pull request, @wgu-taylor-payne!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform-oncall.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Aug 20, 2026
@wgu-taylor-payne
wgu-taylor-payne force-pushed the tpayne/view-library-updates-permission branch 2 times, most recently from 0ffca0e to bc06509 Compare August 20, 2026 16:33
BryanttV added a commit to eduNEXT/edx-platform that referenced this pull request Aug 20, 2026
Use COURSES_VIEW_LIBRARY_UPDATES for read access (list/summary endpoints)
and COURSES_MANAGE_LIBRARY_UPDATES for write access (sync/decline).
Course Auditors can now view library update status in read-only mode
while only Editors+ can sync or decline updates.

Updates DownstreamListView, DownstreamSummaryView, and
_load_accessible_block to use authz permissions with legacy fallback.

ENG45-712
@wgu-taylor-payne
wgu-taylor-payne force-pushed the tpayne/view-library-updates-permission branch from bc06509 to ddc8f71 Compare August 21, 2026 18:53
@wgu-taylor-payne
wgu-taylor-payne marked this pull request as ready for review August 21, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

Add courses.view_library_updates enforcement in openedx-platform

2 participants