Skip to content

test: retry transient share-manager migration errors - #3392

Open
fredrikblau wants to merge 1 commit into
opencloud-eu:mainfrom
fredrikblau:issue-3387-retry-migration
Open

test: retry transient share-manager migration errors#3392
fredrikblau wants to merge 1 commit into
opencloud-eu:mainfrom
fredrikblau:issue-3387-retry-migration

Conversation

@fredrikblau

@fredrikblau fredrikblau commented Aug 21, 2026

Copy link
Copy Markdown

Description

The acceptance HTTP helper now retries the specific transient 500 response emitted while the share manager is migrating. Other 500 responses remain non-retryable.

Related Issue

Fixes #3387

Motivation and Context

The share manager intentionally rejects writes during migration with share manager is currently migrating, please retry. Acceptance setup can hit this window while creating a space, causing a flaky test failure.

Issue verification

Verified against the failure recorded in issue #3387: the acceptance test receives HTTP 500 while the share manager is migrating. The current vendored backend path confirms that this exact message is intentionally returned during migration. A live acceptance reproduction was not run because PHP and Composer are unavailable in the environment.

How Has This Been Tested?

  • git diff --check
  • Inspected the current backend migration guard and acceptance request flow.
  • PHP lint/style checks could not run because PHP and Composer are unavailable.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Tests only (no production source changes)

Checklist

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@v-scharf
v-scharf requested review from butonic and rhafer August 21, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky api-test. share manager migration causes space creation to return 500

1 participant