Thumbnails: Check <oc:has-preview> property - #217
Open
guruz wants to merge 1 commit into
Open
Conversation
...instead of assuming it from the mime type to be an image. This fixes (for example) preview for .txt files
Contributor
Author
|
@zerox80 Aren't those x and y way too big? Sample URL: Comes from buildPreviewUri function. 
web UI also uses high values though: &x=1000&y=1000 TODO: Find out why web UI uses &processor=fit Are we potentially wasting bandwidth here both in App and Web UI @micbar ? |
This was referenced Aug 20, 2026
wernrab
approved these changes
Aug 21, 2026
wernrab
left a comment
wernrab
left a comment
Contributor
There was a problem hiding this comment.
Looks consistent (besides the big x and y values discussed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...instead of assuming it from the mime type to be an image. This fixes (for example) preview for .txt files.
Found this thanks to this iOS(!) issue: opencloud-eu/ios#72
Introduced by @micbar in opencloud-eu/reva#214