fix(realtime): preserve Unicode characters in realtime calls session serialization - #3710
Open
piyushrajyadav wants to merge 1 commit into
Open
fix(realtime): preserve Unicode characters in realtime calls session serialization#3710piyushrajyadav wants to merge 1 commit into
piyushrajyadav wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures non-ASCII Unicode characters (such as Cyrillic, Chinese, Japanese, Arabic, etc.) in the session payload for
realtime.calls.create(sync & async) are not converted to\uXXXXescape sequences during serialization.Problem
When passing instructions, names, or other parameters containing non-ASCII characters to
client.realtime.calls.create(..., session=...), Python'sjson.dumps()defaults toensure_ascii=True, converting characters likeПриветinto\u041f\u0440\u0438\u0432\u0435\u0442. This significantly bloats the payload size and leads to excess token consumption upstream.Solution
ensure_ascii=Falsetojson.dumps()in both_Calls.createand_AsyncCalls.createinsrc/openai/lib/_realtime.py.tests/test_realtime_calls_unicode.pyto verify that Unicode characters remain unescaped UTF-8 in both sync and async request payloads.Fixes #2428
How it was tested
Ran the test suite locally:
Output:
Linting:
python -m ruff check src/openai/lib/_realtime.py tests/test_realtime_calls_unicode.py All checks passed!