fix(sessions): release unused SQLAlchemy table-init locks - #4748
Open
rioyu123 wants to merge 1 commit into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes unused SQLAlchemy table-initialization locks remaining in the process-wide registry.
SQLAlchemySession(create_tables=True)currently keeps one initialization lock for every distinct database/table configuration, even after all sessions using that configuration have been released.The registry now holds weak values, while each live session keeps its existing strong lock reference. Sessions sharing a key still use the same lock; the registry guard, initialization ordering and cancellation handling are unchanged.
In a probe creating and discarding sessions for 100,000 distinct configurations, the old registry retained 100,000 entries after collection. The updated registry retained none. The measured allocation delta came from
tracemalloc; it is not RSS or the byte size of the lock objects.Test plan
Checks
.agents/skills/code-change-verification/scripts/run.sh.