ci: test secure-memory builds in the CMake matrix - #1714
Open
Alb3e3 wants to merge 1 commit into
Open
Conversation
|
| Filename | Overview |
|---|---|
| .github/workflows/cmake.yml | Expands the existing matrix to 18 secure-memory/platform/language configurations and adds consistent Debug build and CTest execution; no actionable defect was identified. |
Reviews (1): Last reviewed commit: "ci: test secure-memory builds in the CMa..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1712.
Add secure-memory ON/OFF builds to the existing CMake matrix across Ubuntu,
Windows, macOS and C++11/17/20. Use Debug consistently across generators and run
CTest after building, including the reader/writer suites as well as unit tests.
Verified locally with GCC 15.2: all three CTest suites pass in each of the six
secure-memory/C++ configurations. The pre-#1709 secure build fails on string
allocator mismatches. Restoring only the old
CZStringcleanup call on currentmaster also makes the secure CTest run fail at
ValueTest/CZStringCoverage.Actionlint passes. Windows and macOS still need the GitHub runners.
Prepared with AI assistance; the validation commands above were run locally.