Skip to content

Add test asserting that rules should be unique - #183

Open
LDiazN wants to merge 4 commits into
mainfrom
182-unique-rules
Open

Add test asserting that rules should be unique#183
LDiazN wants to merge 4 commits into
mainfrom
182-unique-rules

Conversation

@LDiazN

@LDiazN LDiazN commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

closes #182

@LDiazN LDiazN self-assigned this Aug 25, 2026
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.31%. Comparing base (c8fcc72) to head (ba819e5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   83.24%   83.31%   +0.07%     
==========================================
  Files          89       89              
  Lines        5788     5813      +25     
==========================================
+ Hits         4818     4843      +25     
  Misses        970      970              
Flag Coverage Δ
oonidata 77.87% <ø> (ø)
oonipipeline 86.03% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* Introduce the layer attribute to each rule
* Store all LEGACY_RULES inside of separate list
@hellais
hellais marked this pull request as ready for review August 27, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rules can be duplicated by human error

2 participants