#1441: Accept can-prefixed positive tests - #1448
Open
zaguzovmaksim0-hue wants to merge 1 commit into
Open
zaguzovmaksim0-hue wants to merge 1 commit into
zaguzovmaksim0-hue wants to merge 1 commit into
Conversation
Member
|
Thanks — this does resolve the collision #1441 describes, and it is the direction the issue proposes. One concern before merging: the Assigning to @yegor256 to decide which of the two resolutions the issue offers he wants. Generated by Claude Code |
yegor256
self-requested a review
September 14, 2026 05:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1441.
Aligns
unit-test-is-not-verbwith the siblingbad-test-namerule. Positive test names beginning withcan-are now accepted explicitly; all other positive names continue through the existing OpenNLPVBZverb check.This keeps
accepts-*and ordinary singular-verb names working as before while removing the contradiction wherebad-test-namerequires/permitscan-*but OpenNLP tagscanas a modal (MD) and the Java lint rejects it.The existing positive-name parameterized test now includes
can-read-bytesas a regression case.git diff --checkis clean.The commit was created through GitHub and is cryptographically marked
Verified.