Skip to content

test: enable axe region rule - #6977

Open
yamachi4416 wants to merge 1 commit into
nuxt:v4from
yamachi4416:test-enable-axe-region-rule
Open

yamachi4416 wants to merge 1 commit into
nuxt:v4from
yamachi4416:test-enable-axe-region-rule

Conversation

@yamachi4416

@yamachi4416 yamachi4416 commented Sep 18, 2026

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

  • Enabled the axe region rule (or should it remain disabled?)
  • Implemented a VueWrapper plugin to run axe, avoiding the need to import vitest-axe in every test file

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@github-actions github-actions Bot added the v4 #4488 label Sep 18, 2026
@pkg-pr-new

pkg-pr-new Bot commented Sep 18, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@nuxt/ui@6977

commit: f3f1949

@codspeed

codspeed Bot commented Sep 18, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 31 untouched benchmarks


Comparing yamachi4416:test-enable-axe-region-rule (f3f1949) with v4 (a96823d)

Open in CodSpeed

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 55e29d7f-5da1-43d3-9473-b4b31a80b129

📥 Commits

Reviewing files that changed from the base of the PR and between a96823d and f3f1949.

📒 Files selected for processing (120)
  • .github/contributing/testing.md
  • cli/templates.mjs
  • test/components/Accordion.spec.ts
  • test/components/Alert.spec.ts
  • test/components/AuthForm.spec.ts
  • test/components/Avatar.spec.ts
  • test/components/AvatarGroup.spec.ts
  • test/components/Badge.spec.ts
  • test/components/Banner.spec.ts
  • test/components/BlogPost.spec.ts
  • test/components/BlogPosts.spec.ts
  • test/components/Breadcrumb.spec.ts
  • test/components/Button.spec.ts
  • test/components/Calendar.spec.ts
  • test/components/Card.spec.ts
  • test/components/Carousel.spec.ts
  • test/components/ChangelogVersion.spec.ts
  • test/components/ChangelogVersions.spec.ts
  • test/components/ChatMessage.spec.ts
  • test/components/ChatMessages.spec.ts
  • test/components/ChatPalette.spec.ts
  • test/components/ChatPrompt.spec.ts
  • test/components/ChatPromptSubmit.spec.ts
  • test/components/ChatReasoning.spec.ts
  • test/components/ChatShimmer.spec.ts
  • test/components/ChatTool.spec.ts
  • test/components/Checkbox.spec.ts
  • test/components/CheckboxGroup.spec.ts
  • test/components/Chip.spec.ts
  • test/components/Collapsible.spec.ts
  • test/components/ColorPicker.spec.ts
  • test/components/CommandPalette.spec.ts
  • test/components/Container.spec.ts
  • test/components/ContextMenu.spec.ts
  • test/components/DashboardGroup.spec.ts
  • test/components/DashboardNavbar.spec.ts
  • test/components/DashboardPanel.spec.ts
  • test/components/DashboardResizeHandle.spec.ts
  • test/components/DashboardSearch.spec.ts
  • test/components/DashboardSearchButton.spec.ts
  • test/components/DashboardSidebar.spec.ts
  • test/components/DashboardSidebarCollapse.spec.ts
  • test/components/DashboardSidebarToggle.spec.ts
  • test/components/DashboardToolbar.spec.ts
  • test/components/Drawer.spec.ts
  • test/components/DropdownMenu.spec.ts
  • test/components/Editor.spec.ts
  • test/components/EditorDragHandle.spec.ts
  • test/components/EditorToolbar.spec.ts
  • test/components/Empty.spec.ts
  • test/components/Error.spec.ts
  • test/components/FieldGroup.spec.ts
  • test/components/FileUpload.spec.ts
  • test/components/Footer.spec.ts
  • test/components/FooterColumns.spec.ts
  • test/components/Form.spec.ts
  • test/components/FormField.spec.ts
  • test/components/Header.spec.ts
  • test/components/Input.spec.ts
  • test/components/InputDate.spec.ts
  • test/components/InputMenu.spec.ts
  • test/components/InputNumber.spec.ts
  • test/components/InputRating.spec.ts
  • test/components/InputTags.spec.ts
  • test/components/InputTime.spec.ts
  • test/components/Kbd.spec.ts
  • test/components/Link.spec.ts
  • test/components/Listbox.spec.ts
  • test/components/Main.spec.ts
  • test/components/Marquee.spec.ts
  • test/components/Modal.spec.ts
  • test/components/NavigationMenu.spec.ts
  • test/components/Page.spec.ts
  • test/components/PageAnchors.spec.ts
  • test/components/PageAside.spec.ts
  • test/components/PageBody.spec.ts
  • test/components/PageCTA.spec.ts
  • test/components/PageCard.spec.ts
  • test/components/PageColumns.spec.ts
  • test/components/PageFeature.spec.ts
  • test/components/PageGrid.spec.ts
  • test/components/PageHeader.spec.ts
  • test/components/PageHero.spec.ts
  • test/components/PageLinks.spec.ts
  • test/components/PageList.spec.ts
  • test/components/PageLogos.spec.ts
  • test/components/PageSection.spec.ts
  • test/components/Pagination.spec.ts
  • test/components/PinInput.spec.ts
  • test/components/Popover.spec.ts
  • test/components/PricingPlan.spec.ts
  • test/components/PricingPlans.spec.ts
  • test/components/PricingTable.spec.ts
  • test/components/Progress.spec.ts
  • test/components/ProgressGroup.spec.ts
  • test/components/RadioGroup.spec.ts
  • test/components/Select.spec.ts
  • test/components/SelectMenu.spec.ts
  • test/components/Separator.spec.ts
  • test/components/Sidebar.spec.ts
  • test/components/Skeleton.spec.ts
  • test/components/Slideover.spec.ts
  • test/components/Slider.spec.ts
  • test/components/Splitter.spec.ts
  • test/components/Stepper.spec.ts
  • test/components/Switch.spec.ts
  • test/components/Table.spec.ts
  • test/components/Tabs.spec.ts
  • test/components/Textarea.spec.ts
  • test/components/Timeline.spec.ts
  • test/components/Toast.spec.ts
  • test/components/Tooltip.spec.ts
  • test/components/Tree.spec.ts
  • test/components/User.spec.ts
  • test/components/prose/Callout.spec.ts
  • test/components/prose/Card.spec.ts
  • test/components/prose/CodeTree.spec.ts
  • test/nuxt/setup.ts
  • test/utils/setup.ts
  • test/utils/vue-wrapper-plugin.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The test setup now installs an axe() method on Vue Test Utils wrappers. The method temporarily attaches detached wrapper elements to the document, runs the accessibility check, and restores their position. Component tests, CLI templates, and testing documentation now use wrapper.axe(). Global disabling of the region rule was removed.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Merge Risk: ⚪ Minimal · up to f3f19

The accessibility-test migration remains ready to merge; the investigated setup and DOM-cleanup paths do not leave an actionable current-head failure.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 5…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: enabling the axe region accessibility rule. It is concise and specific.
Description check ✅ Passed The description directly covers the changes. It mentions enabling the axe region rule and adding a VueWrapper plugin to run axe without repeated vitest-axe imports.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant