node-api: make object property arrays const

[umuoy1]

Make property_names and property_values const in node_api_create_object_with_properties() to match their read-only semantics.

Refs: nodejs/node-addon-api#1735 (comment)

[nodejs-github-bot]

Review requested:

• @nodejs/node-api

[legendecas]

Thanks! FWIW, this API has already been documented as taking const napi_value* property_[names|values] in https://github.com/nodejs/node/blob/main/doc/api/n-api.md?plain=1#L2697-L2702

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (0544741) to head (d7027a1).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #65621      +/-   ##
==========================================
- Coverage   90.07%   90.05%   -0.02%     
==========================================
  Files         751      751              
  Lines      254921   254921              
  Branches    48129    48127       -2     
==========================================
- Hits       229627   229578      -49     
- Misses      16479    16513      +34     
- Partials     8815     8830      +15     

Files with missing lines	Coverage Δ
src/js_native_api_v8.cc	76.63% <ø> (ø)

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/76650/