src,doc,test: gate alpha version tag behind a macro - #65567
Open
lazerg wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
lazerg
force-pushed
the
fix/issue-65566-alpha-tag
branch
from
August 26, 2026 16:20
ccce945 to
68ebf14
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65567 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01%
==========================================
Files 751 751
Lines 254778 254737 -41
Branches 48089 48067 -22
==========================================
- Hits 229494 229456 -38
- Misses 16464 16475 +11
+ Partials 8820 8806 -14 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NODE_ALPHA_MAJOR_VERSIONis always defined, so the#ifdefguard around the alpha tag was true for every release build and v26.8.0 shipped asv26.8.0-alpha.0.0.0. The tag now hangs off a separateNODE_VERSION_IS_ALPHAflag, mirroring howNODE_VERSION_IS_LTSworks, so a stable line just leaves the flag at 0 rather than relying on the three alpha macros being deleted.test-release-changelogalso checksprocess.versionagainst the macros now, and that runs on release proposals where the release bit is set.This on its own won't fix the shipped binaries, v26.x still needs a backport and a new patch release.
Fixes: #65566