Skip to content

doc: clarify security triage dispositions and permission boundaries - #65436

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
RafaelGSS:security-triage-permission-boundaries
Aug 26, 2026
Merged

doc: clarify security triage dispositions and permission boundaries#65436
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
RafaelGSS:security-triage-permission-boundaries

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

Clarify SECURITY.md by defining security triage dispositions, documenting same-process self-harm exclusions, and separating Permission Model reports into vulnerability, security-interest, and excluded cases. Also correct the worker_threads guidance: workers with modified execArgv or env may not inherit the parent permission configuration, while worker creation itself remains gated by --allow-worker.

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 20, 2026
@RafaelGSS RafaelGSS added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 20, 2026
Comment thread SECURITY.md Outdated
Comment on lines +159 to +162
* **Vulnerability**: Reachable through an element Node.js does not trust and
causes disclosure or loss of integrity or confidentiality of protected data,
arbitrary code execution, or runtime unavailability under the DoS criteria
described below.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might just be me, but I find this line slightly hard to follow as it's written. I think the wording is easy to overlap with vulnerabilities that we reject due to requiring untrusted input.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a suggestion?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this? But non-blocking if others prefer the original version:

Suggested change
* **Vulnerability**: Reachable through an element Node.js does not trust and
causes disclosure or loss of integrity or confidentiality of protected data,
arbitrary code execution, or runtime unavailability under the DoS criteria
described below.
* **Vulnerability**: A Node.js defect that an untrusted party can exploit to
disclose protected data, compromise its integrity or confidentiality, execute
arbitrary code, or make the runtime unavailable under the DoS criteria below.

@RafaelGSS RafaelGSS Aug 24, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m just confused with what β€œprotected data” means here. Someone could reasonably interpret β€œprotected” as protected by application authorization, filesystem permissions, the Permission Model, or something else outside Node’s threat model

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I just kept that term as it was in the original

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main confusion was with this part:

Vulnerability: Reachable through an element Node.js does not trust

But, perhaps need to rethink the whole line.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread SECURITY.md Outdated
@RafaelGSS
RafaelGSS force-pushed the security-triage-permission-boundaries branch from 62bdb7d to 470829e Compare August 25, 2026 19:34
@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 26, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 26, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

This pull request has multiple commits, but no landing policy was selected.

Add commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. to land it as one commit, or commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. to land the commits separately.

The pull request was removed from the Commit Queue and labeled commit-queue-failed An error occurred while landing this pull request using GitHub Actions. . After resolving the failure, remove that label and add commit-queue Add this label to land a pull request using GitHub Actions. to retry.

Full Commit Queue output
- Loading data for nodejs/node/pull/65436
βœ”  Done loading data for nodejs/node/pull/65436
----------------------------------- PR info ------------------------------------
Title      doc: clarify security triage dispositions and permission boundaries (#65436)
Author     Rafael Gonzaga <rafael.nunu@hotmail.com> (@RafaelGSS)
Branch     RafaelGSS:security-triage-permission-boundaries -> nodejs:main
Labels     doc, author ready, commit-queue
Commits    2
 - doc: clarify security triage dispositions and permission boundaries
 - Update SECURITY.md
Committers 1
 - RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/65436
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65436
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
--------------------------------------------------------------------------------
   β„Ή  This PR was created on Thu, 20 Aug 2026 15:49:45 GMT
   βœ”  Approvals: 4
   βœ”  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65436#pullrequestreview-4985181411
   βœ”  - Rich Trott (@Trott): https://github.com/nodejs/node/pull/65436#pullrequestreview-4985423029
   βœ”  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/65436#pullrequestreview-4987024577
   βœ”  - Beth Griggs (@BethGriggs): https://github.com/nodejs/node/pull/65436#pullrequestreview-5029178420
   βœ”  Last GitHub CI successful
   β„Ή  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   βœ”  No git cherry-pick in progress
   βœ”  No git am in progress
   βœ”  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
βœ”  origin/main is now up-to-date
- Downloading patch for 65436
From https://github.com/nodejs/node
 * branch                  refs/pull/65436/merge -> FETCH_HEAD
βœ”  Fetched commits as 49c87ef145e1..470829efa225
--------------------------------------------------------------------------------
[main 318ae7849c] doc: clarify security triage dispositions and permission boundaries
 Author: RafaelGSS <rafael.nunu@hotmail.com>
 Date: Thu Aug 20 12:48:56 2026 -0300
 1 file changed, 58 insertions(+), 3 deletions(-)
[main 5493251280] Update SECURITY.md
 Author: Rafael Gonzaga <rafael.nunu@hotmail.com>
 Date: Tue Aug 25 14:20:49 2026 -0300
 1 file changed, 4 insertions(+), 4 deletions(-)
   βœ”  Patches applied
There are 2 commits in the PR. Attempting autorebase.
(node:409) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: clarify security triage dispositions and permission boundaries

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/65436
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 55668d568c] doc: clarify security triage dispositions and permission boundaries
 Author: RafaelGSS <rafael.nunu@hotmail.com>
 Date: Thu Aug 20 12:48:56 2026 -0300
 1 file changed, 58 insertions(+), 3 deletions(-)
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update SECURITY.md

PR-URL: https://github.com/nodejs/node/pull/65436
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 88875d02df] Update SECURITY.md
 Author: Rafael Gonzaga <rafael.nunu@hotmail.com>
 Date: Tue Aug 25 14:20:49 2026 -0300
 1 file changed, 4 insertions(+), 4 deletions(-)
Successfully rebased and updated refs/heads/main.
--------------------------------------------------------------------------------
   β„Ή  Add `commit-queue-squash` label to land the PR as one commit, or `commit-queue-rebase` to land as separate commits.

View workflow run

@RafaelGSS RafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 26, 2026
@nodejs-github-bot
nodejs-github-bot merged commit a020ac4 into nodejs:main Aug 26, 2026
30 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in a020ac4

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants