doc: clarify security triage dispositions and permission boundaries - #65436
Conversation
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
|
Review requested:
|
| * **Vulnerability**: Reachable through an element Node.js does not trust and | ||
| causes disclosure or loss of integrity or confidentiality of protected data, | ||
| arbitrary code execution, or runtime unavailability under the DoS criteria | ||
| described below. |
There was a problem hiding this comment.
It might just be me, but I find this line slightly hard to follow as it's written. I think the wording is easy to overlap with vulnerabilities that we reject due to requiring untrusted input.
There was a problem hiding this comment.
Do you have a suggestion?
There was a problem hiding this comment.
Maybe something like this? But non-blocking if others prefer the original version:
| * **Vulnerability**: Reachable through an element Node.js does not trust and | |
| causes disclosure or loss of integrity or confidentiality of protected data, | |
| arbitrary code execution, or runtime unavailability under the DoS criteria | |
| described below. | |
| * **Vulnerability**: A Node.js defect that an untrusted party can exploit to | |
| disclose protected data, compromise its integrity or confidentiality, execute | |
| arbitrary code, or make the runtime unavailable under the DoS criteria below. |
There was a problem hiding this comment.
Iβm just confused with what βprotected dataβ means here. Someone could reasonably interpret βprotectedβ as protected by application authorization, filesystem permissions, the Permission Model, or something else outside Nodeβs threat model
There was a problem hiding this comment.
Ah, I just kept that term as it was in the original
There was a problem hiding this comment.
My main confusion was with this part:
Vulnerability: Reachable through an element Node.js does not trust
But, perhaps need to rethink the whole line.
62bdb7d to
470829e
Compare
Commit Queue failedThis pull request has multiple commits, but no landing policy was selected. Add
commit-queue-squash
The pull request was removed from the Commit Queue and labeled
commit-queue-failed
Full Commit Queue output |
|
Landed in a020ac4 |
Clarify
SECURITY.mdby defining security triage dispositions, documenting same-process self-harm exclusions, and separating Permission Model reports into vulnerability, security-interest, and excluded cases. Also correct theworker_threadsguidance: workers with modifiedexecArgvorenvmay not inherit the parent permission configuration, while worker creation itself remains gated by--allow-worker.