dns: better precision for Resolver timeout - #65343
Open
starrify wants to merge 3 commits into
Open
Conversation
Refs: nodejs#65340 Signed-off-by: Peng-Yu Chen <pengyu@libstarrify.so>
Otherwise the event loop time may be late by a considerable amount (e.g. 10~30 ms) and the timer callback would fire earlier by that amount. Timeout processing in c-ares would then fail to recognize a timeout until the next firing of this timer. Fixes: nodejs#65340 Signed-off-by: Peng-Yu Chen <pengyu@libstarrify.so>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65343 +/- ##
=======================================
Coverage 90.11% 90.12%
=======================================
Files 752 752
Lines 251569 251570 +1
Branches 47268 47265 -3
=======================================
+ Hits 226701 226726 +25
+ Misses 16233 16170 -63
- Partials 8635 8674 +39
🚀 New features to boost your workflow:
|
starrify
force-pushed
the
dns-sync-uv-loop-time-upon-start-timer-fix-65340
branch
from
August 17, 2026 10:39
e75ce7d to
2000c78
Compare
This is because ChannelWrap::StartTimer happens before ares_calc_query_timeout usually by a few tens of microseconds but could be longer. An additional allowance of 1 ms helps reduce the chance of missing a timeout. Fixes: nodejs#65340 Signed-off-by: Peng-Yu Chen <pengyu@libstarrify.so>
starrify
force-pushed
the
dns-sync-uv-loop-time-upon-start-timer-fix-65340
branch
from
August 17, 2026 10:40
2000c78 to
d26572d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes: #65340
Edit: Branch force-updated to fix a typo.