Skip to content

quic: apply multiple fixes to flow control signaling - #65309

Closed
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/quic-flow-control-fixes
Closed

quic: apply multiple fixes to flow control signaling#65309
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/quic-flow-control-fixes

Conversation

@jasnell

@jasnell jasnell commented Aug 15, 2026

Copy link
Copy Markdown
Member

Fixing up the QUIC flow control signaling and closed stream handling, expand tests.

Update the flow control handling after the iter streams byte-budget based flow control updates.

@nodejs/quic @pimterry @martenrichter

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 15, 2026
@nodejs-github-bot

This comment was marked as outdated.

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.00000% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.05%. Comparing base (9f37c77) to head (3bdafb6).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/dataqueue/queue.cc 0.00% 15 Missing and 1 partial ⚠️
lib/internal/blob.js 62.06% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65309      +/-   ##
==========================================
- Coverage   90.05%   90.05%   -0.01%     
==========================================
  Files         751      751              
  Lines      254868   254906      +38     
  Branches    48107    48115       +8     
==========================================
+ Hits       229531   229543      +12     
- Misses      16511    16528      +17     
- Partials     8826     8835       +9     
Files with missing lines Coverage Δ
lib/internal/blob.js 87.43% <62.06%> (-0.72%) ⬇️
src/dataqueue/queue.cc 65.79% <0.00%> (-1.77%) ⬇️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Comment thread src/dataqueue/queue.cc
Comment thread src/dataqueue/queue.cc
Comment thread src/quic/streams.cc Outdated
Comment thread src/quic/streams.cc Outdated
Comment thread src/quic/streams.cc Outdated
Comment thread src/quic/streams.h Outdated
Comment thread test/parallel/test-quic-flow-control-bidi-simultaneous-volume.mjs
Comment thread test/parallel/test-quic-flow-control-concurrent-volume.mjs
@martenrichter

martenrichter commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Great addition to find more stalls in the pipeline.
Beside the comments, the rest looks good.

@nodejs-github-bot

nodejs-github-bot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

@jasnell

jasnell commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

@pimterry @Ethan-Arrowood @nodejs/quic ... really need to get this landed before we muck around with more of the quic impl

@jasnell
jasnell force-pushed the jasnell/quic-flow-control-fixes branch 2 times, most recently from 242734c to d889ee8 Compare August 25, 2026 02:51

@pimterry pimterry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of small points where I think we could be stricter and cover related cases, but nothing major. Happy to merge as-is or extend for the various notes here, up to you.

Comment thread src/quic/http3.cc Outdated
Comment thread src/quic/application.cc
Comment thread src/quic/streams.cc Outdated
Comment thread src/quic/streams.cc Outdated
Comment thread src/quic/streams.cc
Comment thread src/quic/streams.cc Outdated
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@jasnell
jasnell force-pushed the jasnell/quic-flow-control-fixes branch from d889ee8 to 3bdafb6 Compare August 27, 2026 04:10
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@jasnell jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 27, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@Ethan-Arrowood Ethan-Arrowood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM. Tests coverage is great. Had my agent help me review the rest of the implementation and it didn't find anything either. One minor nit that can honestly be ignored unless you're doing another commit anyways.

Comment thread test/parallel/test-quic-flow-control-credit-reclaim.mjs
jasnell added a commit that referenced this pull request Aug 27, 2026
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #65309
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@jasnell

jasnell commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

Landed in 05a8e91

@jasnell jasnell closed this Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants