test: add coverage for removeEventListener boolean capture - #65245
Open
lazerg wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65245 +/- ##
==========================================
+ Coverage 90.15% 90.20% +0.04%
==========================================
Files 751 751
Lines 253443 253443
Branches 47729 47756 +27
==========================================
+ Hits 228496 228622 +126
+ Misses 16201 16072 -129
- Partials 8746 8749 +3 🚀 New features to boost your workflow:
|
avivkeller
approved these changes
Aug 13, 2026
Member
|
This needs a rebase. |
removeEventListener(type, fn, true) never matched a listener added the same way, because removeEventListener compared options?.capture === true directly while addEventListener flattened a boolean third argument via validateEventListenerOptions(). The underlying fix landed independently in nodejs#64894 (worker: add support for Web Workers), as a side effect of an unrelated refactor, so this PR now only adds the regression test that would have caught it. WPT does not cover this path: the EventTarget-removeEventListener.any.js test is skipped in test/wpt/status/dom/events.json. Fixes: nodejs#65244 Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
lazerg
force-pushed
the
fix/issue-65244-remove-listener-capture-boolean
branch
from
August 23, 2026 22:13
dd80e58 to
66ee4d8
Compare
trivikr
changed the title
trivikr
approved these changes
Aug 23, 2026
trivikr
added
request-ci
Contributor
Author
|
Rebased onto main. The removeEventListener fix already landed in #64894, an unrelated Web Workers PR, as a side effect of that change. So this PR now only adds the regression test. WPT skips this test path (EventTarget-removeEventListener.any.js), so nothing else guards against this bug coming back. CI is green. |
trivikr
added
the
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removeEventListener()readcaptureoff the options object only, so the boolean shorthandtarget.removeEventListener('foo', fn, true)was flattened tocapture: falseand never matched a listener registered with capture on.addEventListener()already handles the boolean form, so the two went out of sync and the listener stayed attached. Browsers remove it.Fixes #65244