doc: clarify ICU source layout for --with-icu-source - #62011
Conversation
|
Review requested:
|
| The directory passed to `--with-icu-source` must contain the extracted ICU | ||
| source layout (for example, `source/data/in/icudt*l.dat`). A plain Git checkout | ||
| of the ICU repository is not sufficient unless it has been prepared to match | ||
| this layout. |
There was a problem hiding this comment.
I'm not sure this is incredibly clear with respect to what the paths or "prepared to match" mean. Converting from the source code tree to the compiled source archive is an active build step (make dist), not just a "layout"; I don't think we need to mention what to do with a checked-out source tree, only that it's not the way to do it.
| The directory passed to `--with-icu-source` must contain the extracted ICU | |
| source layout (for example, `source/data/in/icudt*l.dat`). A plain Git checkout | |
| of the ICU repository is not sufficient unless it has been prepared to match | |
| this layout. | |
| (Note that simply cloning the icu4c repository will not work here; the source | |
| directory must have been unpacked from the compiled `-sources` archive.) |
|
|
||
| ```bash | ||
| ./configure --with-intl=full-icu --with-icu-source=http://url/to/icu.tgz | ||
| ``` | ||
|
|
||
| #### Windows | ||
|
|
||
| First unpack latest ICU to `deps/icu` | ||
| [icu4c-**##.#**-src.tgz](https://icu.unicode.org/download) (or `.zip`) | ||
| as `deps/icu` (You'll have: `deps/icu/source/...`) | ||
|
|
||
| ```powershell | ||
| .\vcbuild full-icu | ||
| ``` |
There was a problem hiding this comment.
Also need to update the archive names here.
|
This pull request has been marked as stale due to 90 days of inactivity. |
Use the reviewer's wording for the note about cloning icu4c, and update the archive name in the Windows section to match. Co-authored-by: Renegade334 <Renegade334@users.noreply.github.com>
|
Thanks @Renegade334 — applied both. Used your wording verbatim for the icu4c note, since you're right that |
Fixes #60947
Summary
Clarifies
--with-icu-sourcebuild docs to match current ICU release packaging and expected directory layout:icu4c-##.#-src.tgztoicu4c-##.#-sources.tgz.--with-icu-sourcemust point to an extracted ICU source archive layout.Validation
Ran markdown lint on the changed file:
Result: exit code
0.