Skip to content

ci: ignore openjs-foundation.slack.com for markdown link checks - #2610

Merged
MikeMcC399 merged 1 commit into
nodejs:mainfrom
MikeMcC399:ignore-patterns-slack-links
Aug 23, 2026
Merged

ci: ignore openjs-foundation.slack.com for markdown link checks#2610
MikeMcC399 merged 1 commit into
nodejs:mainfrom
MikeMcC399:ignore-patterns-slack-links

Conversation

@MikeMcC399

Copy link
Copy Markdown
Contributor

Description

Add https://openjs-foundation.slack.com to ignorePatterns in https://github.com/nodejs/docker-node/blob/main/markdown_link_check_config.json

Motivation and Context

Links in CONTRIBUTING > Discussion Areas are now causing 403 Forbidden errors when running check:markdown-links:

ERROR: 2 dead links found!
[✖] https://openjs-foundation.slack.com/archives/C0ALS3UDE8G → Status: 403
[✖] https://openjs-foundation.slack.com/archives/C019MGJQ8RH → Status: 403

These links can however be accessed in Google Chrome in an incognito window, so it appears that Slack has increased security against automated checks.

Testing Details

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
@MikeMcC399 MikeMcC399 added bug ci CI (Continuous Integration) workflows labels Aug 20, 2026
@MikeMcC399 MikeMcC399 self-assigned this Aug 20, 2026
@MikeMcC399
MikeMcC399 marked this pull request as ready for review August 20, 2026 09:52
@MikeMcC399
MikeMcC399 requested review from nschonni and sxa August 21, 2026 15:36

@nschonni nschonni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of a bunch of these ignores, because they'll hide if the links ever actually end up as 404s, but I'll approve

@MikeMcC399

Copy link
Copy Markdown
Contributor Author

I'm not a fan of a bunch of these ignores, because they'll hide if the links ever actually end up as 404s, but I'll approve

I don't know of any alternative, otherwise the markdown-link-check will be permanently red, and then nobody will look at it if there is an additional failing URL.

See also tcort/markdown-link-check#109 as an open issue describing the problem.

@MikeMcC399
MikeMcC399 merged commit 8c1da55 into nodejs:main Aug 23, 2026
2 checks passed
@MikeMcC399
MikeMcC399 deleted the ignore-patterns-slack-links branch August 23, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci CI (Continuous Integration) workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants