Skip to content

test: use Vite+ PR 2346 preview - #874

Draft
fengmk2 wants to merge 2 commits into
masterfrom
agent/test-vite-plus-preview
Draft

test: use Vite+ PR 2346 preview#874
fengmk2 wants to merge 2 commits into
masterfrom
agent/test-vite-plus-preview

Conversation

@fengmk2

@fengmk2 fengmk2 commented Aug 19, 2026

Copy link
Copy Markdown
Member

Test the Vite+ preview build from voidzero-dev/vite-plus#2346 in urllib.

This change pins vite-plus and @voidzero-dev/vite-plus-core to commit build 940a1ea. It adds the registry bridge configuration that pnpm needs. It also updates the pnpm overrides and lockfile that vp migrate --no-interactive generated.

GitHub Actions disables SFW for each Vite+ setup step. SFW rejects the registry bridge certificate on Linux.

The preview installer used the new split directory layout on macOS. vp install, vp check, vp test, vp run typecheck, and vp run build pass.

The generic vp build command does not apply to this library. It expects an index.html application entry.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 713b4ad7-7762-4a8b-a7af-8dab3cee9495

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.24%. Comparing base (64aa2b2) to head (a5c36ac).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #874   +/-   ##
=======================================
  Coverage   94.24%   94.24%           
=======================================
  Files          10       10           
  Lines         747      747           
  Branches      235      235           
=======================================
  Hits          704      704           
  Misses         40       40           
  Partials        3        3           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Aug 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/node-modules/urllib@874

commit: a5c36ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant