Fix AIO webhook worker command - #15401
Conversation
Signed-off-by: Loi Nguyen <vanloi999@gmail.com>
|
Current head |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
| .. code-block:: | ||
|
|
||
| set -e; while true; do sudo docker exec -it nextcloud-aio-nextcloud docker exec -it nextcloud-aio-nextcloud sudo -E -u www-data php occ background-job:worker -v -t 60 "OCA\WebhookListeners\BackgroundJobs\WebhookCall"; done | ||
| set -e; while true; do sudo docker exec -it nextcloud-aio-mastercontainer docker exec -it nextcloud-aio-nextcloud sudo -E -u www-data php occ background-job:worker -v -t 60 "OCA\WebhookListeners\BackgroundJobs\WebhookCall"; done |
There was a problem hiding this comment.
| set -e; while true; do sudo docker exec -it nextcloud-aio-mastercontainer docker exec -it nextcloud-aio-nextcloud sudo -E -u www-data php occ background-job:worker -v -t 60 "OCA\WebhookListeners\BackgroundJobs\WebhookCall"; done | |
| set -e; while true; do sudo docker exec --user www-data nextcloud-aio-nextcloud php occ background-job:worker -v -t 60 "OCA\WebhookListeners\BackgroundJobs\WebhookCall"; done |
There was a problem hiding this comment.
I don't know why you suggest this but I think the change would be worthwhile to merge without your suggestion, too, correct?
I'm wondering why to call docker inside the mastercontainer in the first place. It's controlling the same docker daemon as from the host system, isn't it?
There was a problem hiding this comment.
Yeah it doesnt make sense. That why I added this suggestion
There was a problem hiding this comment.
Alright, thank you for the confirmation!
|
@lntutor Thank you for your contribution, and sorry that it took so long to review it! Your change fixes the actual execution, but @szaimen's requested change remove a useless indirection, and even improves the change in our eyes. Could you apply the suggestion? Then we'd happily merge this! Thanks! |
☑️ Resolves
🖼️ Screenshots
Not applicable; this corrects a command example without changing visual documentation.
✅ Checklist
codespelland addressed any spelling issuesValidation:
sphinx-lint,codespell, and the warning-as-error Administration Manual HTML build all pass.