Preserve false and null response results - #150
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Track whether result was explicitly supplied so JSON-RPC responses preserve false and null instead of replacing both with an empty object. Update the generator, templates, generated Ruby interface, and RBS together.
Reproduction
ResponseMessage.new(id: 1, result: false) and an explicit result: nil currently serialize result as an empty object because truthiness is used to choose the fallback. The focused external model fails on 3.17.0.6 and current main, then passes with this change.
Verification
No tests were changed. This source-only patch was identified and verified during an AI-assisted dependency audit.