Give the Copy/ConstructDefault dispatch helpers external linkage (clang 23 -Wunused-template) - #860
Merged
Conversation
They live in an anonymous namespace in a header, so every translation unit that includes cubeb_utils.h without using them gets internal-linkage function templates with no instantiations. clang 23.1.0 diagnoses that under -Wall (-Wunused-template), breaking -Werror builds such as Firefox's. Move them to a detail namespace instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tag-dispatch overloads of
CopyandConstructDefaultincubeb_utils.hlive in an anonymous namespace inside a header, so every translation unit that includes the header without using them gets internal-linkage function templates with no instantiations. clang 23.1.0 diagnoses exactly that under-Wall:which breaks Firefox's
-Werrorbuild with clang 23. Move the helpers to adetailnamespace so they have external linkage; behaviour is unchanged. clang-formatted with the repository's.clang-format.