Bug 2072313 - Accept query-string params on Reminders add - #2751
Merged
Merged
Conversation
add() only read from the JSON body. Reuse the same merge_request_params helper as bugs 2065171/2065173/2072305 instead of writing another copy. No whitelist needed here: create() only reads three named keys, not the whole params hash.
dklawren
requested changes
Sep 18, 2026
…lformed JSON from merge_request_params
dklawren
requested changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reminders.pm's add() only read parameters from the JSON POST body. Adds the query-string merge that the REST docs promise, reusing the same merge_request_params helper as bugs 2065171/2065173/2072305.
Depends on 2072305 per the bug dependency (both introduce the same shared helper; will collapse to one copy once either merges).
Changes
merge_request_paramsnow returns($params, $error)instead of a bare hashref, so a request body that fails to decode as JSON is reported back asrest_malformed_jsonrather than silently ignoredmerge_request_params: build params from$c->req->params->names/param()instead of->to_hash, so a repeated query-string key (e.g.?note=a¬e=b) collapses to a scalar instead of an arrayref reaching an unvalidated fielduser_error('rest_malformed_json')if the body doesn't decodeTest plan
rest_malformed_jsonReferences
rest_malformed_jsoninstead of being silently treated as empty params