feat(vue): Централизованная тема через VueTools getActiveTheme - #738
Conversation
|
Слил поверх #702 и актуальной Проверил на dev (VueTools 1.2.0-pl):
Блокирует этот PR только база: #702 нужно исправить (поле
|
Limit success severity to Modx preset via getPrimarySaveSeverity so Aura keeps primary green. Cover OrderEditProductDialog and add helper unit tests (#738 review).
06c9c9d to
789ea14
Compare
|
@biz87 Спасибо за ревью. База #702: ветка перебазирована на актуальный
Мелочь: Тесты: Коммит: см. latest на ветке. |
Resolve the active PrimeVue theme from the VueTools `vuetools.theme`
system setting instead of hardcoding Aura in every manager entry.
- Add `primevueTheme.js` helper: spreads `getActiveTheme()` and forces
`darkModeSelector: 'none'` so manager chrome stays light. Works for
both aura `{ theme: { preset } }` and modx `{ theme: ModxManagerTheme }`.
- Migrate all 11 entries + main.js off the hardcoded Aura preset to the
helper; externalize `@vuetools/useTheme` in vite.config.js.
- Make `formStyles.js` runtime inject a no-op under the Modx preset
(Modx owns control height/density); keep it for Aura.
- Theme-aware CSS: alias `--ms3-accent-primary` to `--p-primary-color`,
use `--p-modx-space-panel` (with fallbacks) for mt-3/mb-3, and widen
select/multiselect filters to 100% in main.css.
- Add `severity="success"` to primary Save buttons in dialog footers
across order, settings, and catalog grids (fine on Aura too).
- Tighten the VueTools import-map check in 3 manager controllers to also
require `vuetools/theme`; bump VueTools resolver to 1.2.0-pl and update
the `ms3_vuetools_required` lexicon (ru+en) to mention >= 1.2.0.
Add getManagerPrimeVueConfig() and isModxManagerTheme() so entries share one locale+theme setup; help.js keeps theme-only path.
… check Revert accent/--p-modx spacing that broke default Aura; restore cssLayer false in the theme helper; extract import-map check to one include; unify help.js on getManagerPrimeVueConfig.
Limit success severity to Modx preset via getPrimarySaveSeverity so Aura keeps primary green. Cover OrderEditProductDialog and add helper unit tests (#738 review).
789ea14 to
b1173ef
Compare
* fix(mgr): align Vue Manager visuals with MODX chrome Unify primary/success to AA-safe #4e8136 (preset + CSS var inject for VueTools-external PrimeVue), flatten ProductDataFields Card/for-id, fix option_fields under ONLY_FULL_GROUP_BY, and polish Utilities/Uppy/ vtabs/a11y/lexicons (#615). * fix(mgr): polish Vue Manager density and gallery affordances Match MODX primary green, unify toolbar/tab spacing, and make gallery upload and bulk actions clearer and keyboard-friendly. * fix(mgr): unify control heights and product links form layout Force buttons and AutoComplete dropdowns to the shared 2.25rem control height, and fix product links search/dialog spacing inside .vueApp. * fix(mgr): drop Aura recolor and fix MariaDB option GROUP BY VueTools keeps theme ownership (#701/#738): no :root primary inject and no second Aura chunk. Success stays a semantic color. Group every selected msOption column so ONLY_FULL_GROUP_BY works on MariaDB.
Описание
Часть B #701: менеджер берёт PrimeVue-тему из VueTools (
getActiveTheme/@vuetools/useTheme), а не хардкодит Aura. Дефолт остаётся Aura через настройкуvuetools.theme. Пресет Modx включается flip'ом VueTools без пересборки MS3.Стек на Part A (#702 barrel/guard/cache-bust). База PR —
feat/issue-701-primevue-barrel; после merge #702 перенаправить наbeta.Что сделано:
getManagerPrimeVueConfig()(darkModeSelector: 'none',cssLayer: false) во всех entries +main.jsformStylesinject только для Aura (shouldInjectFormStylesOverride)vuetools/theme(общийvue_core_check.inc.php)severity="success"на primary Save; accent/spacing шкалу Aura не ломаем (откат ошибочного alias на--p-primary-color)Тип изменений
Связанные Issues
Closes #701
Depends on #702. Связано: #640, vueTools#22.
Как это было протестировано?
Ручная проверка (нужна VueTools >= 1.2.0):
vuetools.theme=aura— вид как сейчас;=modx— density/токены Modx; VueTools 1.1.x — MODX-алерт, не ошибка линковкиgetActiveTheme.composer ci:php/composer test,npm run lint:ci,composer stan/ GitHub Actions CI)Конфигурация тестирования:
feat/issue-701-centralized-theme(поверх feat(vue): Salvage PrimeVue barrel, cache-bust, and i18n #702)Чеклист
composer stan/ CI jobPHPStan)npm run lint:ciдля Vue)Дополнительные заметки
size="small"из feat(vue): ModxManagerTheme и выравнивание UI менеджера #640 не переносили (scope Part B / Aura safety).beta.