Skip to content

fix: prevent unfollow counter from underflowing #7346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EpicPix wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

fix: prevent unfollow counter from underflowing #7346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion apps/labrinth/src/routes/v3/projects.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3467,7 +3467,7 @@ pub async fn project_unfollow_internal(
"querying database for `project_unfollow_internal`",
)?;

sqlx::query!(
let result = sqlx::query!(
"
DELETE FROM mod_follows
WHERE follower_id = $1 AND mod_id = $2
Expand All @@ -3480,6 +3480,14 @@ pub async fn project_unfollow_internal(
.wrap_internal_err(
"querying database for `project_unfollow_internal`",
)?;
// make sure that we actually removed the follow,
// because between the `SELECT` and the transaction starting, the follow status could've changed
// if we don't check, then you can make the counter go down when you're not followed
if result.rows_affected() == 0 {
return Err(ApiError::Request(eyre::eyre!(
"You are not following this project!",
)));
}

transaction
.commit()
Expand Down