Skip to content

fix: enable saving of subtechnique-of relationships - #960

Merged
jondricek merged 1 commit into
nextfrom
fix-relationship-creation
Sep 21, 2026
Merged

jondricek merged 1 commit into
nextfrom
fix-relationship-creation

Conversation

@adpare

@adpare adpare commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

The frontend tried to create the subtechnique-of relationship before the new subtechnique itself had been saved. The relationship pointed to a child revision that did not exist yet, so the backend rejected it.

In this PR, for a new subtechnique, we save the child technique first, then create its subtechnique-of relationship and sync tactics afterward.

Related to PR open on the rest-api

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.28%. Comparing base (5f6b572) to head (e3ca922).

Files with missing lines Patch % Lines
src/app/classes/stix/technique.ts 0.00% 18 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             beta     #960      +/-   ##
==========================================
- Coverage   47.98%   47.28%   -0.70%     
==========================================
  Files         208      208              
  Lines       27966    27980      +14     
  Branches     2082     2057      -25     
==========================================
- Hits        13419    13230     -189     
- Misses      14455    14659     +204     
+ Partials       92       91       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adpare
adpare marked this pull request as ready for review September 17, 2026 18:46
@jondricek
jondricek changed the base branch from beta to next September 21, 2026 18:22
@jondricek
jondricek merged commit 003fd34 into next Sep 21, 2026
4 checks passed
@jondricek
jondricek deleted the fix-relationship-creation branch September 21, 2026 18:23
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 4.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants