Fix VML style parsing on netstandard2.0 - #131
Conversation
Use the compatible string.Split overload so release builds succeed across all target frameworks.
There was a problem hiding this comment.
🟢 Approval recommended
The change is minimal, directly addresses netstandard2.0 compatibility, and does not alter the parsing behavior beyond the intended overload swap.
Pull request overview
Updates VML style parsing to use a string.Split(char[], int) overload compatible with netstandard2.0, addressing the packaging/build failure encountered during the initial v0.41.0 release run.
Changes:
- Replaced
string.Split(char, int)usage with achar[]-based overload supported bynetstandard2.0. - Preserved the existing “split into exactly two parts” behavior for parsing
property:valueVML style declarations.
File summaries
| File | Description |
|---|---|
| src/MiniPdf/ExcelReader.cs | Adjusts VML style declaration splitting to a netstandard2.0-compatible Split overload while keeping two-part parsing behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| foreach (var declaration in style.Split(';')) | ||
| { | ||
| var parts = declaration.Split(':', 2); | ||
| var parts = declaration.Split(new[] { ':' }, 2); |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe VML style parser now uses the explicit character-array overload of ChangesVML style parsing
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to VML style parsing keeps the same two-part colon split behavior while restoring netstandard2.0 build compatibility, with no remaining merge-readiness risk. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
Summary
string.Split(char[], int)overload supported bynetstandard2.0v0.41.0run failed during buildValidation
dotnet build src/MiniPdf/MiniPdf.csproj -c Release --no-restoredotnet test tests/MiniPdf.Tests/MiniPdf.Tests.csproj -c Release --no-restore(185 passed)Failed release run: https://github.com/mini-software/MiniPdf/actions/runs/33874247411
Summary by CodeRabbit