Skip to content

Fix VML style parsing on netstandard2.0 - #131

Merged
shps951023 merged 1 commit into
mainfrom
fix/netstandard-vml-style-split
Sep 4, 2026
Merged

Fix VML style parsing on netstandard2.0#131
shps951023 merged 1 commit into
mainfrom
fix/netstandard-vml-style-split

Conversation

@shps951023

@shps951023 shps951023 commented Sep 4, 2026

Copy link
Copy Markdown
Member

Summary

  • use the string.Split(char[], int) overload supported by netstandard2.0
  • preserve the existing two-part VML style parsing behavior
  • unblock NuGet packaging after the initial v0.41.0 run failed during build

Validation

  • dotnet build src/MiniPdf/MiniPdf.csproj -c Release --no-restore
  • dotnet test tests/MiniPdf.Tests/MiniPdf.Tests.csproj -c Release --no-restore (185 passed)

Failed release run: https://github.com/mini-software/MiniPdf/actions/runs/33874247411

Summary by CodeRabbit

  • Refactor
    • Updated internal style parsing without changing user-visible behavior.

Use the compatible string.Split overload so release builds succeed across all target frameworks.
Copilot AI lite review requested due to automatic review settings September 4, 2026 12:53
@shps951023 shps951023 self-assigned this Sep 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is minimal, directly addresses netstandard2.0 compatibility, and does not alter the parsing behavior beyond the intended overload swap.

Pull request overview

Updates VML style parsing to use a string.Split(char[], int) overload compatible with netstandard2.0, addressing the packaging/build failure encountered during the initial v0.41.0 release run.

Changes:

  • Replaced string.Split(char, int) usage with a char[]-based overload supported by netstandard2.0.
  • Preserved the existing “split into exactly two parts” behavior for parsing property:value VML style declarations.
File summaries
File Description
src/MiniPdf/ExcelReader.cs Adjusts VML style declaration splitting to a netstandard2.0-compatible Split overload while keeping two-part parsing behavior.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 3749 to +3751
foreach (var declaration in style.Split(';'))
{
var parts = declaration.Split(':', 2);
var parts = declaration.Split(new[] { ':' }, 2);
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 501de8f6-5cbc-439e-9d34-acb7639a08df

📥 Commits

Reviewing files that changed from the base of the PR and between 3d49e87 and 40ae7b9.

📒 Files selected for processing (1)
  • src/MiniPdf/ExcelReader.cs

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The VML style parser now uses the explicit character-array overload of Split. The delimiter and maximum split count remain unchanged.

Changes

VML style parsing

Layer / File(s) Summary
Use explicit split overload
src/MiniPdf/ExcelReader.cs
ReadVmlStylePoints now calls Split(new[] { ':' }, 2) instead of Split(':', 2).

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 40ae7

VML style parsing keeps the same two-part colon split behavior while restoring netstandard2.0 build compatibility, with no remaining merge-readiness risk.

Suggested reviewers: enzosam

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: updating VML style parsing for netstandard2.0 compatibility.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/netstandard-vml-style-split

Comment @coderabbitai help to get the list of available commands.

@shps951023
shps951023 merged commit 5cbc9c9 into main Sep 4, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants