fix: honor explicit pause requests while smart stepping - #2413
Open
debugmcpdev wants to merge 1 commit into
Open
fix: honor explicit pause requests while smart stepping#2413debugmcpdev wants to merge 1 commit into
debugmcpdev wants to merge 1 commit into
Conversation
Contributor
|
debugmcpdev please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicit DAP pause in skipped or unmapped code can be acknowledged and then consumed by automatic stepping, leaving the debuggee running without a usable
stoppedevent.Honor the explicit pause intent already recorded by
Thread.pause()and reset the automatic-step counter. A manual pause can now expose an internal or generated frame; ordinary stepping, pauses without explicit pause intent, and the existing breakpoint/exception/entry exemptions retain their behavior. No launch defaults or public configuration change.Fixes #2412
Validation
Tested on Windows x64 with Node v24.14.1, based on
41bd9bb831a46c2668cab14d8455e8e3bff58477.continuedevents without astoppedevent. With the fix, it pauses, reads the stack, evaluates an expression, and resumes.npm run compile,npm run test:types,npm run test:unit(284 passing), andnpm run test:lintpass.npm run test:golden: 435 passing, 8 pending, 2 failing. The Denodoesn't duplicate --allow-allfailure also reproduces on unpatched main.pretty print sources / bpspasses when rerun on both main and this branch; a focused rerun with the new pause regression has 2 passing tests.smartStep: true. Downstream dogfooding through mcp-debugger's development proxy also succeeds: pause an idle mcp-debugger server, inspect/evaluate its state, hit a source-mapped TypeScript breakpoint in its HTTP handler, step over, and resume an HTTP 200 response.