Ignore empty crash report files - #14730
Draft
Sean McManus (sean-mcmanus) wants to merge 2 commits into
Draft
Conversation
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
September 2, 2026 22:30
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Watcher re-registration can clear active reservations and cause duplicate crash processing.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Prevents empty crash-report placeholders from generating false telemetry while allowing later writes to be processed.
Changes:
- Tracks pending delayed reads per crash filename.
- Leaves zero-byte crash reports untouched.
File summaries
| File | Description |
|---|---|
Extension/src/LanguageServer/extension.ts |
Updates crash-file scheduling and empty-file handling. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent empty native crash-report placeholders from being classified and uploaded as crashes. Track delayed reads per file so a later write to the same file is still processed normally.
Root cause
The crash watcher introduced in #11858 assumes every file change represents a completed report. The missing-signal fallback added in #13493 consequently classifies a zero-byte file as
SIGMISSING, logs it as a crash, and deletes it. A report file can be observed before its crash header has been written, which can produce false telemetry and remove the path before a later real crash writes its report.Fix
Use a per-file pending set only while a delayed read is scheduled. Release the filename before reading, and leave zero-byte files untouched without logging telemetry. A later write can then produce another change event and schedule normal processing, while non-empty crash-report parsing remains unchanged.