-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Implement session state tracking for "Run and Debug" button when Inte… #14719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Prashant Kumar Rai (8prashant)
wants to merge
8
commits into
microsoft:main
Choose a base branch
from
8prashant:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
47035c5
Implement session state tracking for "Run and Debug" button when Inte…
8prashant a47a3b0
Merge branch 'main' into main
8prashant b29443f
Enhance session state tracking for build and debug by updating folder…
8prashant 4bcb9bf
Fix build and debug folder session state tracking
8prashant 174afba
Potential fix for pull request finding
8prashant c8f544d
Merge branch 'main' into main
8prashant 9fe6518
Potential fix for pull request finding
8prashant 23ebb0b
Merge branch 'main' into main
sean-mcmanus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
Extension/test/scenarios/SingleRootProject/tests/buildAndDebug.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /* -------------------------------------------------------------------------------------------- | ||
| * Copyright (c) Microsoft Corporation. All Rights Reserved. | ||
| * See 'LICENSE' in the project root for license information. | ||
| * ------------------------------------------------------------------------------------------ */ | ||
|
|
||
| import * as assert from 'assert'; | ||
| import { suite, test } from 'mocha'; | ||
| import * as vscode from 'vscode'; | ||
| import { updateBuildAndDebugSessionState } from '../../../../src/Debugger/extension'; | ||
| import { SessionState } from '../../../../src/sessionState'; | ||
|
|
||
| suite("BuildAndDebug SessionState Tests", () => { | ||
| test("updateBuildAndDebugSessionState sets false when editor is undefined", () => { | ||
| updateBuildAndDebugSessionState(undefined); | ||
| assert.strictEqual(SessionState.buildAndDebugIsSourceFile.get(), false); | ||
| assert.strictEqual(SessionState.buildAndDebugIsFolderOpen.get(), true); | ||
| }); | ||
|
|
||
| test("updateBuildAndDebugSessionState sets false for non-C/C++ editor", () => { | ||
| const mockEditor: any = { | ||
| document: { | ||
| uri: vscode.Uri.file("test.txt"), | ||
| languageId: "plaintext" | ||
| } | ||
| }; | ||
| updateBuildAndDebugSessionState(mockEditor); | ||
| assert.strictEqual(SessionState.buildAndDebugIsSourceFile.get(), false); | ||
| assert.strictEqual(SessionState.buildAndDebugIsFolderOpen.get(), true); | ||
| }); | ||
|
|
||
| test("updateBuildAndDebugSessionState sets true for C/C++ source file", () => { | ||
| const workspaceFolder = vscode.workspace.workspaceFolders?.[0] ?? assert.fail("No workspace folder available"); | ||
| const mockEditor: any = { | ||
| document: { | ||
| uri: vscode.Uri.joinPath(workspaceFolder.uri, "main.cpp"), | ||
| languageId: "cpp" | ||
| } | ||
| }; | ||
| updateBuildAndDebugSessionState(mockEditor); | ||
| assert.strictEqual(SessionState.buildAndDebugIsSourceFile.get(), true); | ||
| assert.strictEqual(SessionState.buildAndDebugIsFolderOpen.get(), true); | ||
| }); | ||
|
|
||
| test("updateBuildAndDebugSessionState sets false for C/C++ header file", () => { | ||
| const workspaceFolder = vscode.workspace.workspaceFolders?.[0] ?? assert.fail("No workspace folder available"); | ||
| const mockEditor: any = { | ||
| document: { | ||
| uri: vscode.Uri.joinPath(workspaceFolder.uri, "header.h"), | ||
| languageId: "cpp" | ||
| } | ||
| }; | ||
| updateBuildAndDebugSessionState(mockEditor); | ||
| assert.strictEqual(SessionState.buildAndDebugIsSourceFile.get(), false); | ||
| assert.strictEqual(SessionState.buildAndDebugIsFolderOpen.get(), true); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨Copilot (agent146): [Minor] Please add focused regression coverage for the event-driven behavior rather than testing only the exported helper. These four tests call
updateBuildAndDebugSessionStatedirectly, so they would still pass if any of the newonDidChangeActiveTextEditor,onDidOpenTextDocument, oronDidChangeWorkspaceFoldersregistrations were absent. They also never use a C++ URI outside the open workspace, so they would have passed the prior global-folder implementation as well. At minimum, add an external C++ source case that assertsisSourceFile === trueandisFolderOpen === false, plus one listener-driven transition (ideally an active-document language change while IntelliSense is disabled) to cover the behavior this PR fixes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prashant Kumar Rai (@8prashant) FYI, my agents can add the regression coverage for you in a follow up PR if you do not want to....however, I don't think my GitHub agents have those instructions so I might have to directly inform them.
Also, I've been really busy -- I'll try to review your PRs as soon as I can.