docs: the Python reference runtime has shipped, not underway - #3048
Merged
Justin Chu (justinchuby) merged 1 commit intoSep 15, 2026
Merged
Justin Chu (justinchuby) merged 1 commit into
Justin Chu (justinchuby) merged 1 commit into
Conversation
README.md and docs/index.md both said a Python-only reference runtime was underway. OnnxReferenceRuntimeEvaluator has since shipped, is exported from onnxscript.evaluator, and is parametrized into the eager-mode tests.
Justin Chu (justinchuby)
approved these changes
Sep 15, 2026
Justin Chu (justinchuby)
enabled auto-merge (squash)
September 15, 2026 16:24
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3048 +/- ##
=======================================
Coverage 72.73% 72.73%
=======================================
Files 265 265
Lines 32358 32358
Branches 3069 3069
=======================================
Hits 23536 23536
Misses 7779 7779
Partials 1043 1043 ☔ View full report in Codecov by Harness. |
Justin Chu (justinchuby)
merged commit Sep 15, 2026
08898ad
into
microsoft:main
26 of 32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README.md:46anddocs/index.md:34both still say "there is a Python-only reference runtime for ONNX underway that will also be supported". It is not underway, it shipped.onnxscript/_internal/evaluator.py:529definesclass OnnxReferenceRuntimeEvaluator(BaseEvaluator), whose_evalrunsonnx.reference.ReferenceEvaluator. It is public API, listed inonnxscript/evaluator.py__all__at line 22 next toORTEvaluator, andtests/eager_mode_test.pyparametrizes the eager-mode tests across both evaluators.So the two places a new user reads first are the only places saying the feature does not exist yet.
I reworded both to say ONNX Runtime is the default and the reference runtime is available as
onnxscript.evaluator.OnnxReferenceRuntimeEvaluator, and left the surrounding bullets alone.docs/index.mdkeeps its{{ onnxscript }}substitution.Running
python docs/update_readme.pyafter the edit produces no further change, so theupdate_readmejob'sgit diff --exit-code -- README.mdstill passes. My change is in the Design Overview prose, not the generatedupdate-readmecode stub.Same shape as #3012, which corrected a
check_modelclaim to match the code.