Skip to content

feat: add configurable box border style - #456

Merged
cpendery (cpendery) merged 1 commit into
microsoft:mainfrom
manrods:feat/configurable-box-border-style
Aug 25, 2026
Merged

feat: add configurable box border style#456
cpendery (cpendery) merged 1 commit into
microsoft:mainfrom
manrods:feat/configurable-box-border-style

Conversation

@manrods

@manrods Manuel R. Sabella (manrods) commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a validated boxBorderStyle configuration option with square as the backward-compatible default
  • support square (┌ ┐ └ ┘) and rounded (╭ ╮ ╰ ╯) corners across suggestion and description boxes
  • keep renderBox pure by resolving configuration at the composition root and passing a typed, immutable style through the UI
  • add coverage for TOML validation, defaults, box rendering, and style propagation

Design

BoxBorderStyle is derived from one runtime list shared with the AJV schema. The configuration loader returns a resolved configuration snapshot, while the renderer receives only the visual option it needs. Border glyphs remain private and exhaustively typed.

This avoids coupling rendering utilities to the global configuration singleton and keeps tests free of global-state mutation.

Testing

  • npm run build
  • npm run lint
  • npm test -- --runInBand
    • 207 passed
    • 10 skipped
    • 93 snapshots passed

Closes #452

@manrods

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@cpendery

Copy link
Copy Markdown
Member

Hey Manuel R. Sabella (@manrods), I think your PR is more complicated than necessary, please take a look at https://github.com/microsoft/inshellisense/pull/454/changes

@manrods

Copy link
Copy Markdown
Contributor Author

Noted! Working on a simpler solution.

@manrods
Manuel R. Sabella (manrods) force-pushed the feat/configurable-box-border-style branch from 0ffc4b1 to cd99e05 Compare August 24, 2026 16:32
@cpendery
cpendery (cpendery) merged commit c06fe37 into microsoft:main Aug 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a configurable square or rounded box border style

2 participants