feat: add configurable box border style - #456
Merged
cpendery (cpendery) merged 1 commit intoAug 25, 2026
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Member
|
Hey Manuel R. Sabella (@manrods), I think your PR is more complicated than necessary, please take a look at https://github.com/microsoft/inshellisense/pull/454/changes |
Contributor
Author
|
Noted! Working on a simpler solution. |
Manuel R. Sabella (manrods)
force-pushed
the
feat/configurable-box-border-style
branch
from
August 24, 2026 16:32
0ffc4b1 to
cd99e05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
boxBorderStyleconfiguration option withsquareas the backward-compatible defaultsquare(┌ ┐ └ ┘) androunded(╭ ╮ ╰ ╯) corners across suggestion and description boxesrenderBoxpure by resolving configuration at the composition root and passing a typed, immutable style through the UIDesign
BoxBorderStyleis derived from one runtime list shared with the AJV schema. The configuration loader returns a resolved configuration snapshot, while the renderer receives only the visual option it needs. Border glyphs remain private and exhaustively typed.This avoids coupling rendering utilities to the global configuration singleton and keeps tests free of global-state mutation.
Testing
npm run buildnpm run lintnpm test -- --runInBandCloses #452