Misc. containerd-shim-lcow-v2 fixes for confidential - #2906
Open
Tingmao Wang (micromaomao) wants to merge 3 commits into
Open
Misc. containerd-shim-lcow-v2 fixes for confidential#2906Tingmao Wang (micromaomao) wants to merge 3 commits into
Tingmao Wang (micromaomao) wants to merge 3 commits into
Conversation
Assisted-by: GitHub-Copilot Signed-off-by: Tingmao Wang <tingmaowang@microsoft.com>
… is started The cleanup code was meant to remove the VMGS if we errors, but currently it always remove it. Assisted-by: GitHub-Copilot Signed-off-by: Tingmao Wang <tingmaowang@microsoft.com>
…lone containers Assisted-by: GitHub-Copilot Signed-off-by: Tingmao Wang <tingmaowang@microsoft.com>
Copilot started reviewing on behalf of
Tingmao Wang (micromaomao)
September 1, 2026 17:06
View session
There was a problem hiding this comment.
Pull request overview
Fixes confidential LCOW sandbox lifecycle handling and standalone container mounts.
Changes:
- Preserves confidential VM boot files after successful configuration.
- Resolves
uvm://mounts for standalone containers. - Uses the correct
<sandboxID>@vmidentifier during shim shutdown.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/guest/runtime/hcsv2/standalone_container.go |
Resolves standalone uVM mounts. |
internal/builder/vm/lcow/specs.go |
Limits confidential-file cleanup to failures. |
internal/builder/vm/lcow/specs_test.go |
Verifies copied confidential files persist. |
cmd/containerd-shim-lcow-v2/manager.go |
Corrects VM lookup during shutdown. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Harsh Rawat (rawahars)
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picked from confidential AI Sandbox PoC