build: drop kata-containers - #18792
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Stale systemd preset configuration and reverse-dependency documentation still reference the removed component.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Removes Kata Containers from Azure Linux build and publication inputs.
Changes:
- Deletes component definition, lock, and publication entry.
- Removes all rendered package sources and support files.
File summaries
| File | Description |
|---|---|
base/comps/kata-containers/kata-containers.comp.toml |
Removes component definition. |
base/comps/components-publish-channels.toml |
Removes publication entry. |
locks/kata-containers.lock |
Removes component lock. |
specs/k/kata-containers/kata-containers.spec |
Removes rendered spec. |
specs/k/kata-containers/sources |
Removes source checksums. |
specs/k/kata-containers/kata-osbuilder.sh |
Removes image-builder script. |
specs/k/kata-containers/kata-osbuilder-generate.service |
Removes systemd unit. |
specs/k/kata-containers/50-kata |
Removes CRI-O configuration. |
specs/k/kata-containers/15-dracut.conf |
Removes dracut configuration. |
specs/k/kata-containers/1001-Remove-warnings-as-compilation-errors.patch |
Removes build patch. |
specs/k/kata-containers/0999-osbuilder-Adjust-agent_version-for-our-builds.patch |
Removes osbuilder patch. |
Review details
Suppressed comments (1)
base/comps/kata-containers/kata-containers.comp.toml:1
- Removing this component makes the reverse-dependency note in
base/comps/rust-libc/rust-libc.comp.toml:7-10inaccurate: it still counts five in-tree consumers and nameskata-containers. Update that comment to describe the remaining four consumers so its compatibility rationale remains reliable.
- Files reviewed: 10/11 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Tobias Brick (tobiasb-ms)
left a comment
There was a problem hiding this comment.
Generally looks good but the copilot comment #18792 (comment) is worth looking into before merging.
Stop building and publishing kata-containers and remove its component definition, lock and rendered sources. Drop the obsolete preset and bump azurelinux-release to 4.0-29 so upgrades receive the cleanup. Correct the rust-libc consumer count. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1fd8ffad-c9e1-4d63-978a-dcab02131c50
60ffe8d to
2c19768
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The component and its publication, lock, rendered artifacts, service preset, and remaining references are consistently removed.
Review details
- Files reviewed: 15/17 changed files
- Comments generated: 0 new
- Review effort level: Balanced
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
9666700
into
microsoft:4.0
Stop building and publishing kata-containers. Remove its component definition, lock and rendered sources to avoid stale build inputs.
Fixes: AB#23671