ci: enforce EditorConfig across repository - #18761
ci: enforce EditorConfig across repository#18761Christopher Co (christopherco) merged 2 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The updated hook configuration should restrict to types: [text] to match the stated intent and avoid scanning binaries, and the PR description indicates existing violations are still outstanding.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the repository’s pre-commit linting configuration to enforce EditorConfig rules more broadly, while carving out documented exclusions for generated or externally managed content.
Changes:
- Expand
editorconfig-checkercoverage from only*.tomlto (intended) all tracked text files. - Add explicit, documented exclusions for generated specs and specific legal/centrally managed/upstream-artifact files.
File summaries
| File | Description |
|---|---|
| .pre-commit-config.yaml | Broadens EditorConfig checking scope and documents path-based exclusions. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
.pipelines/CodeQL/CodeQL.yml is not valid YAML due to incorrect indentation under jobs:.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 2/12 changed files
- Comments generated: 3
- Review effort level: Lite
0d22853 to
0fa6655
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The changes are consistent with the stated goal (repo-wide EditorConfig enforcement + cleanup) and are limited to formatting/regen artifacts without introducing behavioral modifications.
Review details
- Files reviewed: 5/16 changed files
- Comments generated: 0 new
- Review effort level: Lite
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
0fa6655 to
7b7cfaa
Compare
7b7cfaa to
7ad0fc4
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
It includes an uncalled-out functional change to the kernel-doc subpackage contents (removing kernel.changelog.xz), which needs explicit intent/validation or to be split/reverted.
Review details
Suppressed comments (1)
base/comps/kernel/kernel.spec:863
- This removes Source2 and the installation/packaging of
kernel.changelog.xz, which changes the contents of thekernel-docsubpackage (not just formatting). If this is intentional, it should be called out explicitly in the PR description and validated like any other RPM output change (build + smoke-test); if it’s not intentional, please revert these deletions so the shipped documentation remains unchanged.
Source0: kernel-%{specrpmversion}.%{kextraversion}.tar.gz
Source1: Makefile.rhelver
Source10: redhatsecurebootca5.cer
Source13: redhatsecureboot501.cer
- Files reviewed: 8/24 changed files
- Comments generated: 0 new
- Review effort level: Lite
7ad0fc4 to
54be5ef
Compare
54be5ef to
3a5ca05
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The kernel payload change leaves its manual release unchanged and lacks required build and mock validation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 8/24 changed files
- Comments generated: 1
- Review effort level: Balanced
There was a problem hiding this comment.
🟡 Changes recommended
The kernel-doc payload change lacks the required build, RPM inspection, and mock-chroot smoke-test evidence.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 8/24 changed files
- Comments generated: 1
- Review effort level: Balanced
Check tracked text files selected by editorconfig-checker's standard policy while excluding generated, legal, and centrally managed artifacts through native configuration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
452002f to
b50c8cc
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Built-in checker exclusions still omit tracked text files such as patches, contradicting the stated repository-wide coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 8/24 changed files
- Comments generated: 1
- Review effort level: Balanced
There was a problem hiding this comment.
🔵 Needs a closer look
Built-in checker exclusions undermine the stated coverage, and required RPM validation is not documented.
Review details
Suppressed comments (2)
.editorconfig-checker.json:3
- This configuration does not actually enforce EditorConfig on all tracked text files. editorconfig-checker 3.11.1 merges built-in exclusions unless
IgnoreDefaultsis enabled; those defaults include*.patchand*.svg, and this repository has maintained examples underbase/comps/that are outside the explicitspecs/exclusion. EnableIgnoreDefaultsso the hook's inheritedtypes: [text]filter and this explicit exclusion list define the intended scope.
"$schema": "https://raw.githubusercontent.com/editorconfig-checker/editorconfig-checker/v3.11.1/.editorconfig-checker.schema.json",
"Exclude": [
base/comps/kernel/kernel.spec:20
- The validation still lists only pre-commit, but this rebuild removes
kernel.changelog.xzfrom thekernel-docpayload and also changes several component releases.AGENTS.md:14,24-30requires output-affecting local spec/source changes to be built, inspected, and smoke-tested, or to document why a step is impossible. Please add the relevant component build and mock inspection/smoke-test results before approval.
%define azl_pkgrelease 4
- Files reviewed: 10/27 changed files
- Comments generated: 0 new
- Review effort level: Balanced
Format maintained files for repository-wide EditorConfig enforcement, remove the obsolete packaged kernel changelog, and keep the kernel and kernel-headers releases synchronized. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cdca3ce4-e087-4117-a5be-f57de435b9d9
c165edd to
a5a9986
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The RPM payload changes still lack the required build, inspection, and mock smoke-test validation.
Review details
Suppressed comments (1)
base/comps/kernel/kernel.spec:20
- The PR validation still lists only
pre-commit, but this release bump accompanies an RPM payload change (removal ofkernel.changelog.xz).AGENTS.md:24-30requires output-affecting component changes to be built, inspected, and smoke-tested in mock. Please run and report those checks (or document why a step cannot be performed) before merging.
%define azl_pkgrelease 4
- Files reviewed: 10/27 changed files
- Comments generated: 0 new
- Review effort level: Balanced
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
a5a9986 to
b2ec0e8
Compare
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
There was a problem hiding this comment.
🟡 Changes recommended
The kernel-doc payload change still lacks the required build, RPM inspection, and mock-chroot smoke-test validation.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 10/27 changed files
- Comments generated: 0 new
- Review effort level: Balanced
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
|
Bypassing the scratch build check. Dev scratch environment is backed up, and prod scratch environment passed as expected |
c8bec0b
into
microsoft:4.0
Summary
Validation
pre-commit run --all-files --show-diff-on-failure